From: Jakub Kicinski <kuba@kernel•org>
To: "Jürgen Groß" <jgross@suse•com>
Cc: Anthoine Bourgeois <anthoine.bourgeois@vates•tech>,
Stefano Stabellini <sstabellini@kernel•org>,
Oleksandr Tyshchenko <oleksandr_tyshchenko@epam•com>,
Wei Liu <wei.liu@kernel•org>, Paul Durrant <paul@xen•org>,
xen-devel@lists•xenproject.org, netdev@vger•kernel.org,
Elliott Mitchell <ehem+xen@m5p•com>
Subject: Re: [PATCH v2] xen/netfront: Fix TX response spurious interrupts
Date: Fri, 18 Jul 2025 10:12:51 -0700 [thread overview]
Message-ID: <20250718101251.0e67772a@kernel.org> (raw)
In-Reply-To: <4f54ed1a-e265-43db-b4f2-f3c0d3b3dd00@suse.com>
On Fri, 18 Jul 2025 09:19:17 +0200 Jürgen Groß wrote:
> On 17.07.25 16:29, Jakub Kicinski wrote:
> > On Tue, 15 Jul 2025 16:11:29 +0000 Anthoine Bourgeois wrote:
> >> Fixes: b27d47950e48 ("xen/netfront: harden netfront against event channel storms")
> >
> > Not entirely sure who you expect to apply this patch, but if networking
> > then I wouldn't classify this is a fix. The "regression" happened 4
> > years ago. And this patch doesn't seem to be tuning the logic added by
> > the cited commit. I think this is an optimization, -next material, and
> > therefore there should be no Fixes tag here. You can refer to the commit
> > without the tag.
>
> I think in the end it is a fix of the initial xen-netfront.c contribution
> (commit 0d160211965b).
>
> I'm fine to change the Fixes: tag and apply the patch via the Xen tree.
SGTM, FWIW. But I'd like to reiterate my humble recommendation to treat
this as an optimization, and not add the Fixes tag.
next prev parent reply other threads:[~2025-07-18 17:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 16:11 [PATCH v2] xen/netfront: Fix TX response spurious interrupts Anthoine Bourgeois
2025-07-17 14:29 ` Jakub Kicinski
2025-07-18 7:19 ` Jürgen Groß
2025-07-18 17:12 ` Jakub Kicinski [this message]
2025-07-18 8:10 ` Anthoine Bourgeois
2025-07-23 22:23 ` Elliott Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718101251.0e67772a@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=anthoine.bourgeois@vates$(echo .)tech \
--cc=ehem+xen@m5p$(echo .)com \
--cc=jgross@suse$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=oleksandr_tyshchenko@epam$(echo .)com \
--cc=paul@xen$(echo .)org \
--cc=sstabellini@kernel$(echo .)org \
--cc=wei.liu@kernel$(echo .)org \
--cc=xen-devel@lists$(echo .)xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox