From: Simon Horman <horms@kernel•org>
To: Alok Tiwari <alok.a.tiwari@oracle•com>
Cc: somnath.kotur@broadcom•com, ajit.khaparde@broadcom•com,
sriharsha.basavapatna@broadcom•com, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, kuba@kernel•org,
pabeni@redhat•com, netdev@vger•kernel.org
Subject: Re: [PATCH net-next] be2net: Use correct byte order and format string for TCP seq and ack_seq
Date: Fri, 18 Jul 2025 18:01:08 +0100 [thread overview]
Message-ID: <20250718170108.GK2459@horms.kernel.org> (raw)
In-Reply-To: <20250717193552.3648791-1-alok.a.tiwari@oracle.com>
On Thu, Jul 17, 2025 at 12:35:47PM -0700, Alok Tiwari wrote:
> The TCP header fields seq and ack_seq are 32-bit values in network
> byte order as (__be32). these fields were earlier printed using
> ntohs(), which converts only 16-bit values and produces incorrect
> results for 32-bit fields. This patch is changeing the conversion
> to ntohl(), ensuring correct interpretation of these sequence numbers.
>
> Notably, the format specifier is updated from %d to %u to reflect the
> unsigned nature of these fields.
>
> improves the accuracy of debug log messages for TCP sequence and
> acknowledgment numbers during TX timeouts.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle•com>
Reviewed-by: Simon Horman <horms@kernel•org>
next prev parent reply other threads:[~2025-07-18 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 19:35 [PATCH net-next] be2net: Use correct byte order and format string for TCP seq and ack_seq Alok Tiwari
2025-07-18 17:01 ` Simon Horman [this message]
2025-07-19 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718170108.GK2459@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
--cc=sriharsha.basavapatna@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox