From: Jakub Kicinski <kuba@kernel•org>
To: chia-yu.chang@nokia-bell-labs•com
Cc: alok.a.tiwari@oracle•com, pctammela@mojatatu•com,
horms@kernel•org, donald.hunter@gmail•com, xandfury@gmail•com,
netdev@vger•kernel.org, dave.taht@gmail•com, pabeni@redhat•com,
jhs@mojatatu•com, stephen@networkplumber•org,
xiyou.wangcong@gmail•com, jiri@resnulli•us, davem@davemloft•net,
edumazet@google•com, andrew+netdev@lunn•ch, ast@fiberby•net,
liuhangbin@gmail•com, shuah@kernel•org,
linux-kselftest@vger•kernel.org, ij@kernel•org,
ncardwell@google•com, koen.de_schepper@nokia-bell-labs•com,
g.white@cablelabs•com, ingemar.s.johansson@ericsson•com,
mirja.kuehlewind@ericsson•com, cheshire@apple•com,
rs.ietf@gmx•at, Jason_Livingood@comcast•com,
vidhi_goel@apple•com
Subject: Re: [PATCH v24 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc
Date: Fri, 18 Jul 2025 17:54:18 -0700 [thread overview]
Message-ID: <20250718175418.0b6a62c5@kernel.org> (raw)
In-Reply-To: <20250717232427.69216-2-chia-yu.chang@nokia-bell-labs.com>
On Fri, 18 Jul 2025 01:24:22 +0200 chia-yu.chang@nokia-bell-labs•com
wrote:
> + if (!opt || !nla_len(opt)) {
> + NL_SET_ERR_MSG_MOD(extack, "Dualpi2 options are required");
> + return -EINVAL;
> + }
> + err = nla_parse_nested(tb, TCA_DUALPI2_MAX, opt, dualpi2_policy,
> + extack);
> + if (err < 0)
> + return err;
> +
> + q = qdisc_priv(sch);
> + sch_tree_lock(sch);
[...]
> + if (tb[TCA_DUALPI2_STEP_THRESH_PKTS] && tb[TCA_DUALPI2_STEP_THRESH_US]) {
> + NL_SET_ERR_MSG_MOD(extack, "multiple step thresh attributes");
> + return -EINVAL;
> + }
You're missing an unlock, please place the validation before
sch_tree_lock().
--
pw-bot: cr
next prev parent reply other threads:[~2025-07-19 0:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 23:24 [PATCH v24 net-next 0/6] DUALPI2 patch chia-yu.chang
2025-07-17 23:24 ` [PATCH v24 net-next 1/6] sched: Struct definition and parsing of dualpi2 qdisc chia-yu.chang
2025-07-19 0:54 ` Jakub Kicinski [this message]
2025-07-17 23:24 ` [PATCH v24 net-next 2/6] sched: Dump configuration and statistics " chia-yu.chang
2025-07-17 23:24 ` [PATCH v24 net-next 3/6] sched: Add enqueue/dequeue " chia-yu.chang
2025-07-17 23:24 ` [PATCH v24 net-next 4/6] selftests/tc-testing: Fix warning and style check on tdc.sh chia-yu.chang
2025-07-17 23:24 ` [PATCH v24 net-next 5/6] selftests/tc-testing: Add selftests for qdisc DualPI2 chia-yu.chang
2025-07-17 23:24 ` [PATCH v24 net-next 6/6] Documentation: netlink: specs: tc: Add DualPI2 specification chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250718175418.0b6a62c5@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Jason_Livingood@comcast$(echo .)com \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=ast@fiberby$(echo .)net \
--cc=cheshire@apple$(echo .)com \
--cc=chia-yu.chang@nokia-bell-labs$(echo .)com \
--cc=dave.taht@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=g.white@cablelabs$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=ij@kernel$(echo .)org \
--cc=ingemar.s.johansson@ericsson$(echo .)com \
--cc=jhs@mojatatu$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=koen.de_schepper@nokia-bell-labs$(echo .)com \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=liuhangbin@gmail$(echo .)com \
--cc=mirja.kuehlewind@ericsson$(echo .)com \
--cc=ncardwell@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pctammela@mojatatu$(echo .)com \
--cc=rs.ietf@gmx$(echo .)at \
--cc=shuah@kernel$(echo .)org \
--cc=stephen@networkplumber$(echo .)org \
--cc=vidhi_goel@apple$(echo .)com \
--cc=xandfury@gmail$(echo .)com \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox