From: Simon Horman <horms@kernel•org>
To: David Wilder <wilder@us•ibm.com>
Cc: netdev@vger•kernel.org, jv@jvosburgh•net,
pradeeps@linux•vnet.ibm.com, pradeep@us•ibm.com,
i.maximets@ovn•org, amorenoz@redhat•com, haliu@redhat•com,
stephen@networkplumber•org
Subject: Re: [PATCH net-next v6 7/7] bonding: Selftest and documentation for the arp_ip_target parameter.
Date: Sun, 20 Jul 2025 11:37:52 +0100 [thread overview]
Message-ID: <20250720103752.GT2459@horms.kernel.org> (raw)
In-Reply-To: <20250718212430.1968853-8-wilder@us.ibm.com>
On Fri, Jul 18, 2025 at 02:23:43PM -0700, David Wilder wrote:
> This selftest provided a functional test for the arp_ip_target parameter
> both with and without user supplied vlan tags.
>
> and
>
> Updates to the bonding documentation.
>
> Signed-off-by: David Wilder <wilder@us•ibm.com>
> ---
> Documentation/networking/bonding.rst | 11 ++
> .../selftests/drivers/net/bonding/Makefile | 3 +-
> .../drivers/net/bonding/bond-arp-ip-target.sh | 178 ++++++++++++++++++
Hi David,
Recently we have started running shellcheck as part of our CI for Networking.
Excluding SC2317, which flagges code as unreachable due to
the structure of many sleftests, including this one, I think it is trivial
to make bond-arp-ip-target.sh selftest-clean.
As I see there will be a v7 anyway, could you take a look at doing so?
$ shellcheck -e SC2317 ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh
In ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh line 133:
if [ $RET -ne 0 ]; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$RET" -ne 0 ]; then
In ./tools/testing/selftests/drivers/net/bonding/bond-arp-ip-target.sh line 160:
if [ $RET -ne 0 ]; then
^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
if [ "$RET" -ne 0 ]; then
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
And sorry for not flagging this earlier.
For some reason it seemed less clear to me the last time I checked.
next prev parent reply other threads:[~2025-07-20 10:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-18 21:23 [PATCH net-next v6 0/7] bonding: Extend arp_ip_target format to allow for a list of vlan tags David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 1/7] bonding: Adding struct bond_arp_target David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 2/7] bonding: Adding extra_len field to struct bond_opt_value David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 3/7] bonding: arp_ip_target helpers David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 4/7] bonding: Processing extended arp_ip_target from user space David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 5/7] bonding: Update to bond_arp_send_all() to use supplied vlan tags David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 6/7] bonding: Update for extended arp_ip_target format David Wilder
2025-07-18 21:23 ` [PATCH net-next v6 7/7] bonding: Selftest and documentation for the arp_ip_target parameter David Wilder
2025-07-19 1:33 ` Jakub Kicinski
2025-07-21 19:23 ` David Wilder
2025-07-21 20:08 ` Jakub Kicinski
2025-08-08 17:32 ` David Wilder
2025-08-08 17:43 ` Jakub Kicinski
2025-07-20 10:37 ` Simon Horman [this message]
2025-07-21 17:47 ` David Wilder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250720103752.GT2459@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=amorenoz@redhat$(echo .)com \
--cc=haliu@redhat$(echo .)com \
--cc=i.maximets@ovn$(echo .)org \
--cc=jv@jvosburgh$(echo .)net \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pradeep@us$(echo .)ibm.com \
--cc=pradeeps@linux$(echo .)vnet.ibm.com \
--cc=stephen@networkplumber$(echo .)org \
--cc=wilder@us$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox