From: Simon Horman <horms@kernel•org>
To: Tristram.Ha@microchip•com
Cc: Woojung.Huh@microchip•com, andrew@lunn•ch, olteanv@gmail•com,
kuba@kernel•org, robh@kernel•org, krzk+dt@kernel•org,
conor+dt@kernel•org, maxime.chevallier@bootlin•com,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
marex@denx•de, UNGLinuxDriver@microchip•com,
devicetree@vger•kernel.org, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH net-next v4 4/7] net: dsa: microchip: Use different registers for KSZ8463
Date: Fri, 25 Jul 2025 08:29:56 +0100 [thread overview]
Message-ID: <20250725072956.GH1266901@horms.kernel.org> (raw)
In-Reply-To: <DM3PR11MB87360DB5CDD47DF4A64FC33BEC59A@DM3PR11MB8736.namprd11.prod.outlook.com>
On Fri, Jul 25, 2025 at 12:17:26AM +0000, Tristram.Ha@microchip•com wrote:
> > On Thu, Jul 24, 2025 at 02:28:56AM +0000, Tristram.Ha@microchip•com wrote:
> > > > On Wed, Jul 23, 2025 at 02:25:27AM +0000, Tristram.Ha@microchip•com wrote:
> > > > > > On Sun, Jul 20, 2025 at 11:17:03AM +0100, Simon Horman wrote:
> > > > > > > On Fri, Jul 18, 2025 at 06:21:03PM -0700, Tristram.Ha@microchip•com
> > wrote:
...
> > I feel that we are talking past each other.
> > Let's try to find a common understanding.
>
> It is really about the register definition of this specific register.
> In KSZ8863 when presenting in 16-bit the value is 0x07ff, but in KSZ8463
> it is 0xff07. It is the fault of the hardware to define such value.
If the behaviour of this register is different to others, then I guess a
special case is a reasonable approach. Although I would have thought there
is a better way.
I would suggest adding a comment to the code explaining that this is a
special case. And I would suggest revisiting this if more special cases are
needed.
> Note that in the new patch KSZ8463 SPI driver implements its own access
> functions, so native mode is used instead and there is no automatic
> swapping depending on the big-endian or little-endian format. Still this
> code is needed to program the register correctly.
Thanks for taking time to respond to my questions.
I think we should let the matter rest here.
next prev parent reply other threads:[~2025-07-25 7:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-19 1:20 [PATCH net-next v4 0/7] net: dsa: microchip: Add KSZ8463 switch support Tristram.Ha
2025-07-19 1:21 ` [PATCH net-next v4 1/7] dt-bindings: " Tristram.Ha
2025-07-19 1:21 ` [PATCH net-next v4 2/7] net: dsa: microchip: Add KSZ8463 switch support to KSZ DSA driver Tristram.Ha
2025-07-20 10:24 ` Simon Horman
2025-07-19 1:21 ` [PATCH net-next v4 3/7] net: dsa: microchip: Transform register for use with KSZ8463 Tristram.Ha
2025-07-20 15:56 ` Andrew Lunn
2025-07-19 1:21 ` [PATCH net-next v4 4/7] net: dsa: microchip: Use different registers for KSZ8463 Tristram.Ha
2025-07-20 10:17 ` Simon Horman
2025-07-20 10:22 ` Simon Horman
2025-07-23 2:25 ` Tristram.Ha
2025-07-23 16:21 ` Simon Horman
2025-07-24 2:28 ` Tristram.Ha
2025-07-24 21:35 ` Simon Horman
2025-07-25 0:17 ` Tristram.Ha
2025-07-25 7:29 ` Simon Horman [this message]
2025-07-19 1:21 ` [PATCH net-next v4 5/7] net: dsa: microchip: Write switch MAC address differently " Tristram.Ha
2025-07-19 1:21 ` [PATCH net-next v4 6/7] net: dsa: microchip: Setup fiber ports " Tristram.Ha
2025-07-19 1:21 ` [PATCH net-next v4 7/7] net: dsa: microchip: Disable PTP function of KSZ8463 Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250725072956.GH1266901@horms.kernel.org \
--to=horms@kernel$(echo .)org \
--cc=Tristram.Ha@microchip$(echo .)com \
--cc=UNGLinuxDriver@microchip$(echo .)com \
--cc=Woojung.Huh@microchip$(echo .)com \
--cc=andrew@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=edumazet@google$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=marex@denx$(echo .)de \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox