Subject: Re: [PATCH net-next v1] mlxbf_gige: report unknown speed and duplex when link is down

From: Jakub Kicinski <[email-masked]>
Date: Fri, 15 Aug 2025 12:11:02 -0700

On Wed, 13 Aug 2025 12:33:46 -0400 Chris Babroski wrote:
> The "Speed" and "Duplex" fields displayed by ethtool should report
> "Unknown" when the link is down. Currently, the driver always reports
> the initially configured link speed and duplex, regardless of the actual
> link state.
> 
> Implement a get_link_ksettings() callback to update the values reported
> to ethtool based on the link state. When the link is down, the driver
> now reports unknown speed and duplex as expected.

If that's the correct thing to do why is
phy_ethtool_get_link_ksettings() not doing it?

Please explain what makes mlxbf special, and make sure to CC PHY
maintainers on v2.
-- 
pw-bot: cr