Subject: Re: [PATCH v18 01/20] cxl: Add type2 device basic support

From: Jonathan Cameron <[email-masked]>
Date: Thu, 18 Sep 2025 11:55:12 +0100

On Thu, 18 Sep 2025 10:17:27 +0100
[email-masked] wrote:

> From: Alejandro Lucero <[email-masked]>
> 
> Differentiate CXL memory expanders (type 3) from CXL device accelerators
> (type 2) with a new function for initializing cxl_dev_state and a macro
> for helping accel drivers to embed cxl_dev_state inside a private
> struct.
> 
> Move structs to include/cxl as the size of the accel driver private
> struct embedding cxl_dev_state needs to know the size of this struct.
> 
> Use same new initialization with the type3 pci driver.
> 
> Signed-off-by: Alejandro Lucero <[email-masked]>
> Reviewed-by: Jonathan Cameron <[email-masked]>
> Reviewed-by: Dave Jiang <[email-masked]>
> Reviewed-by: Alison Schofield <[email-masked]>

> diff --git a/Documentation/driver-api/cxl/theory-of-operation.rst b/Documentation/driver-api/cxl/theory-of-operation.rst
> index 257f513e320c..ab8ebe7722a9 100644
> --- a/Documentation/driver-api/cxl/theory-of-operation.rst
> +++ b/Documentation/driver-api/cxl/theory-of-operation.rst
> @@ -347,6 +347,9 @@ CXL Core
>  .. kernel-doc:: drivers/cxl/cxl.h
>     :internal:
>  
> +.. kernel-doc:: include/cxl/cxl.h
> +   :internal:
> +

Smells like a merge conflict issue given same entry is already there.

>  .. kernel-doc:: drivers/cxl/acpi.c
>     :identifiers: add_cxl_resources