Subject: Re: [PATCH net-next v3 2/8] selftests: drv-net: base device access API test

From: Jakub Kicinski <[email-masked]>
Date: Tue, 30 Sep 2025 06:32:08 -0700

On Tue, 30 Sep 2025 15:16:43 +0200 Paolo Abeni wrote:
> On 9/28/25 12:54 AM, Jakub Kicinski wrote:
> > diff --git a/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py b/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > index 1462a339a74b..559c572e296a 100644
> > --- a/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > +++ b/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > @@ -13,7 +13,7 @@ KSFT_DIR = (Path(__file__).parent / "../../../../..").resolve()
> >  
> >      # Import one by one to avoid pylint false positives
> >      from net.lib.py import EthtoolFamily, NetdevFamily, NetshaperFamily, \
> > -        NlError, RtnlFamily, DevlinkFamily
> > +        NlError, RtnlFamily, DevlinkFamily, PSPFamily  
> 
> Side question:
> There is a consistent false positive ruff check about this kind of
> change (with the added import being labeled as unused even in a __init__
> file.
> 
> I'm wondering if is possible to explicitly disable such warnings?

I think it's possible to fix them by using __all__
It seemed to work but I wasn't confident enough that it's "the right
thing" to make it part of the series. I'm planning to follow up.