Subject: Re: [PATCH net v2] selftests: net: unify the Makefile formats

From: Jakub Kicinski <[email-masked]>
Date: Mon, 6 Oct 2025 10:30:12 -0700

On Mon, 6 Oct 2025 11:40:59 +0200 Petr Machata wrote:
> > We get a significant number of conflicts between net and net-next
> > because of selftests Makefile changes. People tend to append new
> > test cases at the end of the Makefile when there's no clear sort
> > order. Sort all networking selftests Makefiles, use the following
> > format:  
> 
> If we see weird errors in CI, it might be because tests now run in a
> different order and previously masked missed cleanups are now exposed.

Yes, sorry. I enabled the check before merging this so there's probably
some transient false positives. Which is fine, the pw checks are for
maintainers? :)

> > diff --git a/tools/testing/selftests/drivers/net/dsa/Makefile b/tools/testing/selftests/drivers/net/dsa/Makefile
> > index cd6817fe5be6..699e3565d735 100644
> > --- a/tools/testing/selftests/drivers/net/dsa/Makefile
> > +++ b/tools/testing/selftests/drivers/net/dsa/Makefile
> > @@ -9,11 +9,13 @@ TEST_PROGS = bridge_locked_port.sh \  
> 
> This should have the header converted as well:
> 
> TEST_PROGS := \
> 	bridge_locked_port.sh \

Ack, let me fix when applying.