Subject: Re: [PATCH v19 20/22] sfc: create cxl region

From: Jonathan Cameron <[email-masked]>
Date: Tue, 7 Oct 2025 15:13:36 +0100

On Mon, 6 Oct 2025 11:01:28 +0100
<[email-masked]> wrote:

> From: Alejandro Lucero <[email-masked]>
> 
> Use cxl api for creating a region using the endpoint decoder related to
> a DPA range.
> 
> Add a callback for unwinding sfc cxl initialization when the endpoint port
> is destroyed by potential cxl_acpi or cxl_mem modules removal.
> 
> Signed-off-by: Alejandro Lucero <[email-masked]>
> ---
>  drivers/net/ethernet/sfc/efx_cxl.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/efx_cxl.c b/drivers/net/ethernet/sfc/efx_cxl.c
> index 1a50bb2c0913..79fe99d83f9f 100644
> --- a/drivers/net/ethernet/sfc/efx_cxl.c
> +++ b/drivers/net/ethernet/sfc/efx_cxl.c
> @@ -116,6 +116,14 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  		return PTR_ERR(cxl->cxled);
>  	}
>  
> +	cxl->efx_region = cxl_create_region(cxl->cxlrd, &cxl->cxled, 1);

This follows from earlier comment on patch 18.  I think cxl->cxled is the right
thing to pass in here rather than pretending it's an array by passing
in a pointer to that.

> +	if (IS_ERR(cxl->efx_region)) {
> +		pci_err(pci_dev, "CXL accel create region failed");
> +		cxl_put_root_decoder(cxl->cxlrd);
> +		cxl_dpa_free(cxl->cxled);
> +		return PTR_ERR(cxl->efx_region);
> +	}
> +
>  	probe_data->cxl = cxl;
>  
>  	return 0;
> @@ -124,6 +132,8 @@ int efx_cxl_init(struct efx_probe_data *probe_data)
>  void efx_cxl_exit(struct efx_probe_data *probe_data)
>  {
>  	if (probe_data->cxl) {
> +		cxl_decoder_detach(NULL, probe_data->cxl->cxled, 0,
> +				   DETACH_INVALIDATE);
>  		cxl_dpa_free(probe_data->cxl->cxled);
>  		cxl_put_root_decoder(probe_data->cxl->cxlrd);
>  	}