Subject: Re: [PATCH 1/1] dt-bindings: net: dsa: nxp,sja1105: Add optional clock

From: Vladimir Oltean <[email-masked]>
Date: Tue, 14 Oct 2025 23:07:01 +0300

On Fri, Oct 10, 2025 at 02:34:17PM -0400, Frank Li wrote:
> Add optional clock for OSC_IN and fix the below CHECK_DTBS warnings:
>   arch/arm/boot/dts/nxp/imx/imx6qp-prtwd3.dtb: switch@0 (nxp,sja1105q): Unevaluated properties are not allowed ('clocks' was unexpected)
> 
> Signed-off-by: Frank Li <[email-masked]>
> ---
>  Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> index e9dd914b0734c..607b7fe8d28ee 100644
> --- a/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml
> @@ -41,6 +41,9 @@ properties:
>        therefore discouraged.
>      maxItems: 1
>  
> +  clocks:
> +    maxItems: 1
> +
>    spi-cpha: true
>    spi-cpol: true
>  
> -- 
> 2.34.1
> 

Reviewed-by: Vladimir Oltean <[email-masked]>

with the comment that you might want to add clk_prepare_enable() driver
support for it too. Someone who specifies a clock which isn't fixed
might be taken by surprise by the missing driver logic.