Subject: Re: [PATCH] sysfs: check visibility before changing group attribute ownership

From: Jakub Kicinski <[email-masked]>
Date: Thu, 16 Oct 2025 08:38:35 -0700

On Thu, 16 Oct 2025 12:14:56 +0200 Fernando Fernandez Mancera wrote:
> Since commit 0c17270f9b92 ("net: sysfs: Implement is_visible for
> phys_(port_id, port_name, switch_id)"), __dev_change_net_namespace() can
> hit WARN_ON() when trying to change owner of a file that isn't visible.
> See the trace below:

Dunno much about sysfs but this is what I had in mind so FWIW:

Reviewed-by: Jakub Kicinski <[email-masked]>

I'd be tempted to chuck:

Fixes: 0c17270f9b92 ("net: sysfs: Implement is_visible for phys_(port_id, port_name, switch_id)")

here as well. Or are we certain there are other callers that could have
triggered this earlier?

> Reported-by: Cynthia <[email-masked]>

Perhaps:

Reported-and-bisected-by: ...