From: Greg KH <gregkh@linuxfoundation•org>
To: Nathan Chancellor <nathan@kernel•org>
Cc: Eliav Farber <farbere@amazon•com>,
stable@vger•kernel.org, linux@armlinux•org.uk, jdike@addtoit•com,
richard@nod•at, anton.ivanov@cambridgegreys•com,
dave.hansen@linux•intel.com, luto@kernel•org,
peterz@infradead•org, tglx@linutronix•de, mingo@redhat•com,
bp@alien8•de, x86@kernel•org, hpa@zytor•com, tony.luck@intel•com,
qiuxu.zhuo@intel•com, mchehab@kernel•org, james.morse@arm•com,
rric@kernel•org, harry.wentland@amd•com, sunpeng.li@amd•com,
alexander.deucher@amd•com, christian.koenig@amd•com,
airlied@linux•ie, daniel@ffwll•ch, evan.quan@amd•com,
james.qian.wang@arm•com, liviu.dudau@arm•com,
mihail.atanassov@arm•com, brian.starkey@arm•com,
maarten.lankhorst@linux•intel.com, mripard@kernel•org,
tzimmermann@suse•de, robdclark@gmail•com, sean@poorly•run,
jdelvare@suse•com, linux@roeck-us•net, fery@cypress•com,
dmitry.torokhov@gmail•com, agk@redhat•com, snitzer@redhat•com,
dm-devel@redhat•com, rajur@chelsio•com, davem@davemloft•net,
kuba@kernel•org, peppe.cavallaro@st•com, alexandre.torgue@st•com,
joabreu@synopsys•com, mcoquelin.stm32@gmail•com,
malattia@linux•it, hdegoede@redhat•com, mgross@linux•intel.com,
intel-linux-scu@intel•com, artur.paszkiewicz@intel•com,
jejb@linux•ibm.com, martin.petersen@oracle•com,
sakari.ailus@linux•intel.com, clm@fb•com, josef@toxicpanda•com,
dsterba@suse•com, xiang@kernel•org, chao@kernel•org,
jack@suse•com, tytso@mit•edu, adilger.kernel@dilger•ca,
dushistov@mail•ru, luc.vanoostenryck@gmail•com,
rostedt@goodmis•org, pmladek@suse•com,
sergey.senozhatsky@gmail•com, andriy.shevchenko@linux•intel.com,
linux@rasmusvillemoes•dk, minchan@kernel•org, ngupta@vflare•org,
akpm@linux-foundation•org, kuznet@ms2•inr.ac.ru,
yoshfuji@linux-ipv6•org, pablo@netfilter•org,
kadlec@netfilter•org, fw@strlen•de, jmaloy@redhat•com,
ying.xue@windriver•com, willy@infradead•org, sashal@kernel•org,
ruanjinjie@huawei•com, David.Laight@aculab•com,
herve.codina@bootlin•com, Jason@zx2c4•com, keescook@chromium•org,
kbusch@kernel•org, bvanassche@acm•org, ndesaulniers@google•com,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-um@lists•infradead.org,
linux-edac@vger•kernel.org, amd-gfx@lists•freedesktop.org,
dri-devel@lists•freedesktop.org, linux-arm-msm@vger•kernel.org,
freedreno@lists•freedesktop.org, linux-hwmon@vger•kernel.org,
linux-input@vger•kernel.org, linux-media@vger•kernel.org,
netdev@vger•kernel.org, linux-stm32@st-md-mailman•stormreply.com,
platform-driver-x86@vger•kernel.org, linux-scsi@vger•kernel.org,
linux-staging@lists•linux.dev, linux-btrfs@vger•kernel.org,
linux-erofs@lists•ozlabs.org, linux-ext4@vger•kernel.org,
linux-sparse@vger•kernel.org, linux-mm@kvack•org,
netfilter-devel@vger•kernel.org, coreteam@netfilter•org,
tipc-discussion@lists•sourceforge.net
Subject: Re: [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7
Date: Sun, 19 Oct 2025 14:38:26 +0200 [thread overview]
Message-ID: <2025101905-matter-freezable-39e5@gregkh> (raw)
In-Reply-To: <20251017160924.GA2728735@ax162>
On Fri, Oct 17, 2025 at 05:09:24PM +0100, Nathan Chancellor wrote:
> On Fri, Oct 17, 2025 at 05:03:02PM +0200, Greg KH wrote:
> > On Fri, Oct 17, 2025 at 09:04:52AM +0000, Eliav Farber wrote:
> > > This series backports 27 patches to update minmax.h in the 5.10.y
> > > branch, aligning it with v6.17-rc7.
> > >
> > > The ultimate goal is to synchronize all long-term branches so that they
> > > include the full set of minmax.h changes.
> > >
> > > - 6.12.y has already been backported; the changes are included in
> > > v6.12.49.
> > > - 6.6.y has already been backported; the changes are included in
> > > v6.6.109.
> > > - 6.1.y has already been backported; the changes are currently in the
> > > 6.1-stable tree.
> > > - 5.15.y has already been backported; the changes are currently in the
> > > 5.15-stable tree.
> >
> > With this series applied, on an arm64 server, building 'allmodconfig', I
> > get the following build error.
> >
> > Oddly I don't see it on my x86 server, perhaps due to different compiler
> > versions?
> >
> > Any ideas?
> >
> > thanks,
> >
> > greg k-h
> >
> > ------------------------
> >
> > In function ‘rt2800_txpower_to_dev’,
> > inlined from ‘rt2800_config_channel’ at ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:4022:25:
> > ./../include/linux/compiler_types.h:309:45: error: call to ‘__compiletime_assert_1168’ declared with attribute error: clamp() low limit -7 greater than high limit 15
> > 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > | ^
> > ./../include/linux/compiler_types.h:290:25: note: in definition of macro ‘__compiletime_assert’
> > 290 | prefix ## suffix(); \
> > | ^~~~~~
> > ./../include/linux/compiler_types.h:309:9: note: in expansion of macro ‘_compiletime_assert’
> > 309 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> > | ^~~~~~~~~~~~~~~~~~~
> > ../include/linux/build_bug.h:39:37: note: in expansion of macro ‘compiletime_assert’
> > 39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
> > | ^~~~~~~~~~~~~~~~~~
> > ../include/linux/minmax.h:188:9: note: in expansion of macro ‘BUILD_BUG_ON_MSG’
> > 188 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \
> > | ^~~~~~~~~~~~~~~~
> > ../include/linux/minmax.h:195:9: note: in expansion of macro ‘__clamp_once’
> > 195 | __clamp_once(type, val, lo, hi, __UNIQUE_ID(v_), __UNIQUE_ID(l_), __UNIQUE_ID(h_))
> > | ^~~~~~~~~~~~
> > ../include/linux/minmax.h:218:36: note: in expansion of macro ‘__careful_clamp’
> > 218 | #define clamp_t(type, val, lo, hi) __careful_clamp(type, val, lo, hi)
> > | ^~~~~~~~~~~~~~~
> > ../drivers/net/wireless/ralink/rt2x00/rt2800lib.c:3980:24: note: in expansion of macro ‘clamp_t’
> > 3980 | return clamp_t(char, txpower, MIN_A_TXPOWER, MAX_A_TXPOWER);
> > | ^~~~~~~
>
> Missing commit 3bc753c06dd0 ("kbuild: treat char as always unsigned")?
That's going to be messy to backport, it's not even in 6.1.y, so let's
leave that alone if at all possible.
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-19 12:38 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 9:04 [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7 Eliav Farber
2025-10-17 9:04 ` [PATCH v2 01/27 5.10.y] overflow, tracing: Define the is_signed_type() macro once Eliav Farber
2025-10-17 11:59 ` Greg KH
2025-10-17 12:16 ` Farber, Eliav
2025-10-17 13:21 ` Greg KH
2025-10-17 9:04 ` [PATCH v2 02/27 5.10.y] btrfs: remove duplicated in_range() macro Eliav Farber
2025-10-17 9:04 ` [PATCH v2 03/27 5.10.y] minmax: sanity check constant bounds when clamping Eliav Farber
2025-10-17 9:04 ` [PATCH v2 04/27 5.10.y] minmax: clamp more efficiently by avoiding extra comparison Eliav Farber
2025-10-17 9:04 ` [PATCH v2 05/27 5.10.y] minmax: add in_range() macro Eliav Farber
2025-10-17 9:04 ` [PATCH v2 06/27 5.10.y] minmax: Introduce {min,max}_array() Eliav Farber
2025-10-17 9:04 ` [PATCH v2 07/27 5.10.y] minmax: deduplicate __unconst_integer_typeof() Eliav Farber
2025-10-17 9:05 ` [PATCH v2 08/27 5.10.y] minmax: fix header inclusions Eliav Farber
2025-10-17 9:05 ` [PATCH v2 09/27 5.10.y] minmax: allow min()/max()/clamp() if the arguments have the same signedness Eliav Farber
2025-10-17 9:05 ` [PATCH v2 10/27 5.10.y] minmax: fix indentation of __cmp_once() and __clamp_once() Eliav Farber
2025-10-17 9:05 ` [PATCH v2 11/27 5.10.y] minmax: allow comparisons of 'int' against 'unsigned char/short' Eliav Farber
2025-10-17 9:05 ` [PATCH v2 12/27 5.10.y] minmax: relax check to allow comparison between unsigned arguments and signed constants Eliav Farber
2025-10-17 9:05 ` [PATCH v2 13/27 5.10.y] minmax: avoid overly complicated constant expressions in VM code Eliav Farber
2025-10-17 9:05 ` [PATCH v2 14/27 5.10.y] minmax: add a few more MIN_T/MAX_T users Eliav Farber
2025-10-17 9:05 ` [PATCH v2 15/27 5.10.y] minmax: simplify and clarify min_t()/max_t() implementation Eliav Farber
2025-10-17 9:05 ` [PATCH v2 16/27 5.10.y] minmax: make generic MIN() and MAX() macros available everywhere Eliav Farber
2025-10-17 9:05 ` [PATCH v2 17/27 5.10.y] minmax: don't use max() in situations that want a C constant expression Eliav Farber
2025-10-17 9:05 ` [PATCH v2 18/27 5.10.y] minmax: simplify min()/max()/clamp() implementation Eliav Farber
2025-10-17 9:05 ` [PATCH v2 19/27 5.10.y] minmax: improve macro expansion and type checking Eliav Farber
2025-10-17 9:05 ` [PATCH v2 20/27 5.10.y] minmax: fix up min3() and max3() too Eliav Farber
2025-10-17 9:05 ` [PATCH v2 21/27 5.10.y] minmax.h: add whitespace around operators and after commas Eliav Farber
2025-10-17 9:05 ` [PATCH v2 22/27 5.10.y] minmax.h: update some comments Eliav Farber
2025-10-17 9:05 ` [PATCH v2 23/27 5.10.y] minmax.h: reduce the #define expansion of min(), max() and clamp() Eliav Farber
2025-10-17 9:05 ` [PATCH v2 24/27 5.10.y] minmax.h: use BUILD_BUG_ON_MSG() for the lo < hi test in clamp() Eliav Farber
2025-10-17 9:05 ` [PATCH v2 25/27 5.10.y] minmax.h: move all the clamp() definitions after the min/max() ones Eliav Farber
2025-10-17 9:05 ` [PATCH v2 26/27 5.10.y] minmax.h: simplify the variants of clamp() Eliav Farber
2025-10-17 9:05 ` [PATCH v2 27/27 5.10.y] minmax.h: remove some #defines that are only expanded once Eliav Farber
2025-10-17 15:03 ` [PATCH v2 00/27 5.10.y] Backport minmax.h updates from v6.17-rc7 Greg KH
2025-10-17 16:09 ` Nathan Chancellor
2025-10-19 12:38 ` Greg KH [this message]
2025-10-18 20:07 ` Farber, Eliav
2025-10-19 12:37 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025101905-matter-freezable-39e5@gregkh \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=David.Laight@aculab$(echo .)com \
--cc=Jason@zx2c4$(echo .)com \
--cc=adilger.kernel@dilger$(echo .)ca \
--cc=agk@redhat$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alexandre.torgue@st$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=anton.ivanov@cambridgegreys$(echo .)com \
--cc=artur.paszkiewicz@intel$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=brian.starkey@arm$(echo .)com \
--cc=bvanassche@acm$(echo .)org \
--cc=chao@kernel$(echo .)org \
--cc=christian.koenig@amd$(echo .)com \
--cc=clm@fb$(echo .)com \
--cc=coreteam@netfilter$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dm-devel@redhat$(echo .)com \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=dsterba@suse$(echo .)com \
--cc=dushistov@mail$(echo .)ru \
--cc=evan.quan@amd$(echo .)com \
--cc=farbere@amazon$(echo .)com \
--cc=fery@cypress$(echo .)com \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=fw@strlen$(echo .)de \
--cc=harry.wentland@amd$(echo .)com \
--cc=hdegoede@redhat$(echo .)com \
--cc=herve.codina@bootlin$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=intel-linux-scu@intel$(echo .)com \
--cc=jack@suse$(echo .)com \
--cc=james.morse@arm$(echo .)com \
--cc=james.qian.wang@arm$(echo .)com \
--cc=jdelvare@suse$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jmaloy@redhat$(echo .)com \
--cc=joabreu@synopsys$(echo .)com \
--cc=josef@toxicpanda$(echo .)com \
--cc=kadlec@netfilter$(echo .)org \
--cc=kbusch@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=kuznet@ms2$(echo .)inr.ac.ru \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-btrfs@vger$(echo .)kernel.org \
--cc=linux-edac@vger$(echo .)kernel.org \
--cc=linux-erofs@lists$(echo .)ozlabs.org \
--cc=linux-ext4@vger$(echo .)kernel.org \
--cc=linux-hwmon@vger$(echo .)kernel.org \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linux-sparse@vger$(echo .)kernel.org \
--cc=linux-staging@lists$(echo .)linux.dev \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linux@rasmusvillemoes$(echo .)dk \
--cc=linux@roeck-us$(echo .)net \
--cc=liviu.dudau@arm$(echo .)com \
--cc=luc.vanoostenryck@gmail$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=maarten.lankhorst@linux$(echo .)intel.com \
--cc=malattia@linux$(echo .)it \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=mgross@linux$(echo .)intel.com \
--cc=mihail.atanassov@arm$(echo .)com \
--cc=minchan@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=mripard@kernel$(echo .)org \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=netfilter-devel@vger$(echo .)kernel.org \
--cc=ngupta@vflare$(echo .)org \
--cc=pablo@netfilter$(echo .)org \
--cc=peppe.cavallaro@st$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=platform-driver-x86@vger$(echo .)kernel.org \
--cc=pmladek@suse$(echo .)com \
--cc=qiuxu.zhuo@intel$(echo .)com \
--cc=rajur@chelsio$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=robdclark@gmail$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rric@kernel$(echo .)org \
--cc=ruanjinjie@huawei$(echo .)com \
--cc=sakari.ailus@linux$(echo .)intel.com \
--cc=sashal@kernel$(echo .)org \
--cc=sean@poorly$(echo .)run \
--cc=sergey.senozhatsky@gmail$(echo .)com \
--cc=snitzer@redhat$(echo .)com \
--cc=stable@vger$(echo .)kernel.org \
--cc=sunpeng.li@amd$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tipc-discussion@lists$(echo .)sourceforge.net \
--cc=tony.luck@intel$(echo .)com \
--cc=tytso@mit$(echo .)edu \
--cc=tzimmermann@suse$(echo .)de \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=xiang@kernel$(echo .)org \
--cc=ying.xue@windriver$(echo .)com \
--cc=yoshfuji@linux-ipv6$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox