Subject: Re: [PATCH net-next v5 2/5] bnxt_en: Refactor aux bus functions to be more generic

From: Leon Romanovsky <[email-masked]>
Date: Sun, 19 Oct 2025 15:52:31 +0300

On Tue, Oct 14, 2025 at 01:10:30AM -0700, Pavan Chebbi wrote:
> Up until now there was only one auxiliary device that bnxt
> created and that was for RoCE driver. bnxt fwctl is also
> going to use an aux bus device that bnxt should create.
> This requires some nomenclature changes and refactoring of
> the existing bnxt aux dev functions.
> 
> Convert 'aux_priv' and 'edev' members of struct bnxt into
> arrays where each element contains supported auxbus device's
> data. Move struct bnxt_aux_priv from bnxt.h to ulp.h because
> that is where it belongs. Make aux bus init/uninit/add/del
> functions more generic which will accept aux device type as
> a parameter. Make bnxt_ulp_start/stop functions (the only
> other common functions applicable to any aux device) loop
> through the aux devices to update their config and states.
> 
> Also, as an improvement in code, bnxt_register_dev() can skip
> unnecessary dereferencing of edev from bp, instead use the
> edev pointer from the function parameter.
> 
> Future patches will reuse these functions to add an aux bus
> device for fwctl.
> 
> Reviewed-by: Andy Gospodarek <[email-masked]>
> Signed-off-by: Pavan Chebbi <[email-masked]>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt.c     |  29 ++-
>  drivers/net/ethernet/broadcom/bnxt/bnxt.h     |  13 +-
>  .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c |   2 +-
>  drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 238 ++++++++++--------
>  include/linux/bnxt/ulp.h                      |  23 +-
>  5 files changed, 181 insertions(+), 124 deletions(-)

<...>

> -void bnxt_rdma_aux_device_uninit(struct bnxt *bp)
> +void bnxt_aux_device_uninit(struct bnxt *bp, enum bnxt_auxdev_type idx)
>  {
>  	struct bnxt_aux_priv *aux_priv;
>  	struct auxiliary_device *adev;
>  
>  	/* Skip if no auxiliary device init was done. */
> -	if (!bp->aux_priv)
> +	if (!bp->aux_priv[idx])
>  		return;

<...>

> -void bnxt_rdma_aux_device_del(struct bnxt *bp)
> +void bnxt_aux_device_del(struct bnxt *bp, enum bnxt_auxdev_type idx)
>  {
> -	if (!bp->edev)
> +	if (!bp->edev[idx])
>  		return;

You are not supposed to call these functions if you didn't initialize
auxdev for this idx first. Please don't use defensive programming style
for in-kernel API.

Thanks