Subject: Re: [PATCH net-next 1/4] net: phy: add iterator phy_for_each

From: Jakub Kicinski <[email-masked]>
Date: Tue, 21 Oct 2025 18:24:51 -0700

On Fri, 17 Oct 2025 22:41:12 +0200 Heiner Kallweit wrote:
> +#define phy_for_each(_bus, _phydev)			\
> +	for (_phydev = phy_find_first(_bus); _phydev;	\
> +	     _phydev = phy_find_next(_bus, _phydev))

Wouldn't this better be called mii_for_each_phy() or
mii_bus_for_each_phy() ?

To an outsider and with PHY typologies it may not be
sufficiently obvious that this helper is used to iterate
a all addresses on a MII bus.