From: Byungchul Park <byungchul@sk•com>
To: Pavel Begunkov <asml.silence@gmail•com>
Cc: axboe@kernel•dk, kuba@kernel•org, pabeni@redhat•com,
almasrymina@google•com, davem@davemloft•net, edumazet@google•com,
horms@kernel•org, hawk@kernel•org, ilias.apalodimas@linaro•org,
sdf@fomichev•me, dw@davidwei•uk, ap420073@gmail•com,
dtatulea@nvidia•com, toke@redhat•com, io-uring@vger•kernel.org,
linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
kernel_team@skhynix•com, max.byungchul.park@gmail•com
Subject: Re: [PATCH net-next] page_pool: check if nmdesc->pp is !NULL to confirm its usage as pp for net_iov
Date: Thu, 23 Oct 2025 17:27:50 +0900 [thread overview]
Message-ID: <20251023082750.GA11851@system.software.com> (raw)
In-Reply-To: <8d833a3f-ae18-4ea6-9092-ddaa48290a63@gmail.com>
On Fri, Oct 17, 2025 at 01:33:43PM +0100, Pavel Begunkov wrote:
> On 10/16/25 08:21, Byungchul Park wrote:
> > On Thu, Oct 16, 2025 at 03:36:57PM +0900, Byungchul Park wrote:
> > > ->pp_magic field in struct page is current used to identify if a page
> > > belongs to a page pool. However, ->pp_magic will be removed and page
> > > type bit in struct page e.g. PGTY_netpp should be used for that purpose.
> > >
> > > As a preparation, the check for net_iov, that is not page-backed, should
> > > avoid using ->pp_magic since net_iov doens't have to do with page type.
> > > Instead, nmdesc->pp can be used if a net_iov or its nmdesc belongs to a
> > > page pool, by making sure nmdesc->pp is NULL otherwise.
> > >
> > > For page-backed netmem, just leave unchanged as is, while for net_iov,
> > > make sure nmdesc->pp is initialized to NULL and use nmdesc->pp for the
> > > check.
> >
> > IIRC,
> >
> > Suggested-by: Pavel Begunkov <asml.silence@gmail•com>
>
> Pointing out a problem in a patch with a fix doesn't qualify to
> me as "suggested-by", you don't need to worry about that.
>
> Did you get the PGTY bits merged? There is some uneasiness about
> this patch as it does nothing good by itself, it'd be much better
> to have it in a series finalising the page_pool conversion. And
I also considered that. However, I think the finalizing e.i. removing
pp fields in struct page, would better be done once every thing else has
been ready, so that I can focus on examining more thoroughly if there
aren't accesses through struct page and it can be fianlized safely :-)
Byungchul
> I don't think it simplify merging anyhow, hmm?
>
> ...>> diff --git a/io_uring/zcrx.c b/io_uring/zcrx.c
> > > index 723e4266b91f..cf78227c0ca6 100644
> > > --- a/io_uring/zcrx.c
> > > +++ b/io_uring/zcrx.c
> > > @@ -450,6 +450,10 @@ static int io_zcrx_create_area(struct io_zcrx_ifq *ifq,
> > > area->freelist[i] = i;
> > > atomic_set(&area->user_refs[i], 0);
> > > niov->type = NET_IOV_IOURING;
> > > +
> > > + /* niov->desc.pp is already initialized to NULL by
> > > + * kvmalloc_array(__GFP_ZERO).
> > > + */
>
> Please drop this hunk if you'll be resubmitting, it's not
> needed.
>
> --
> Pavel Begunkov
next prev parent reply other threads:[~2025-10-23 8:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 6:36 [PATCH net-next] page_pool: check if nmdesc->pp is !NULL to confirm its usage as pp for net_iov Byungchul Park
2025-10-16 7:21 ` Byungchul Park
2025-10-17 12:33 ` Pavel Begunkov
2025-10-17 15:13 ` Mina Almasry
2025-10-18 4:46 ` Byungchul Park
2025-10-18 15:05 ` Mina Almasry
2025-10-23 8:27 ` Byungchul Park [this message]
2025-10-16 23:31 ` Byungchul Park
2025-10-17 6:26 ` Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023082750.GA11851@system.software.com \
--to=byungchul@sk$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=ap420073@gmail$(echo .)com \
--cc=asml.silence@gmail$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=hawk@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=ilias.apalodimas@linaro$(echo .)org \
--cc=io-uring@vger$(echo .)kernel.org \
--cc=kernel_team@skhynix$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=max.byungchul.park@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=toke@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox