From: Jakub Kicinski <kuba@kernel•org>
To: Ankan Biswas <spyjetfayed@gmail•com>
Cc: ajit.khaparde@broadcom•com, sriharsha.basavapatna@broadcom•com,
somnath.kotur@broadcom•com, andrew+netdev@lunn•ch,
davem@davemloft•net, edumazet@google•com, pabeni@redhat•com,
netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
skhan@linuxfoundation•org, khalid@kernel•org,
david.hunter.linux@gmail•com,
linux-kernel-mentees@lists•linux.dev
Subject: Re: [PATCH v3] net: ethernet: emulex: benet: fix adapter->fw_on_flash truncation warning
Date: Tue, 28 Oct 2025 18:42:54 -0700 [thread overview]
Message-ID: <20251028184254.1d902b50@kernel.org> (raw)
In-Reply-To: <20251024181541.5532-1-spyjetfayed@gmail.com>
On Fri, 24 Oct 2025 23:45:41 +0530 Ankan Biswas wrote:
> The benet driver copies both fw_ver (32 bytes) and fw_on_flash (32 bytes)
> into ethtool_drvinfo->fw_version (32 bytes), leading to a potential
> string truncation warning when built with W=1.
>
> Store fw_on_flash in ethtool_drvinfo->erom_version instead, which some
> drivers use to report secondary firmware information.
You are changing user-visible behavior to silence a W=1 warning.
I can't stress enough how bad of an idea this is.
Please find a better fix.. or leave this code be.
next prev parent reply other threads:[~2025-10-29 1:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 18:15 [PATCH v3] net: ethernet: emulex: benet: fix adapter->fw_on_flash truncation warning Ankan Biswas
2025-10-29 1:42 ` Jakub Kicinski [this message]
2025-10-29 7:00 ` Ankan Biswas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028184254.1d902b50@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=ajit.khaparde@broadcom$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=david.hunter.linux@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=khalid@kernel$(echo .)org \
--cc=linux-kernel-mentees@lists$(echo .)linux.dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=somnath.kotur@broadcom$(echo .)com \
--cc=spyjetfayed@gmail$(echo .)com \
--cc=sriharsha.basavapatna@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox