From: "Michael S. Tsirkin" <mst@redhat•com>
To: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
Cc: netdev@vger•kernel.org, "Jason Wang" <jasowang@redhat•com>,
"Eugenio Pérez" <eperezma@redhat•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
"Eric Dumazet" <edumazet@google•com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Paolo Abeni" <pabeni@redhat•com>,
"Heng Qi" <hengqi@linux•alibaba.com>,
"Willem de Bruijn" <willemb@google•com>,
"Jiri Pirko" <jiri@resnulli•us>,
"Alvaro Karsz" <alvaro.karsz@solid-run•com>,
virtualization@lists•linux.dev
Subject: Re: [PATCH net v4 0/4] fixes two virtio-net related bugs.
Date: Thu, 30 Oct 2025 04:02:57 -0400 [thread overview]
Message-ID: <20251030033025-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251029030913.20423-1-xuanzhuo@linux.alibaba.com>
On Wed, Oct 29, 2025 at 11:09:09AM +0800, Xuan Zhuo wrote:
> As discussed in http://lore.kernel.org/all/20250919013450.111424-1-xuanzhuo@linux.alibaba.com
> Commit #1 Move the flags into the existing if condition; the issue is that it introduces a
> small amount of code duplication.
>
> Commit #3 is new to fix the hdr len in tunnel gso feature.
I think these are completely independent right?
When there is no dependency it is best to send
patches separately, this way they do not block each other.
>
> Thanks.
>
> v4:
> 1. add commit "virtio-net: Ensure hdr_len is not set unless the header is forwarded to the device." @Jason
>
> v3:
> 1. recode the #3 for tunnel gso, and test it
>
>
>
> Xuan Zhuo (4):
> virtio-net: fix incorrect flags recording in big mode
> virtio-net: Ensure hdr_len is not set unless the header is forwarded
> to the device.
> virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN
> virtio-net: correct hdr_len handling for tunnel gso
>
> drivers/net/virtio_net.c | 16 +++++++++----
> include/linux/virtio_net.h | 48 ++++++++++++++++++++++++++++++--------
> 2 files changed, 49 insertions(+), 15 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
prev parent reply other threads:[~2025-10-30 8:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 3:09 [PATCH net v4 0/4] fixes two virtio-net related bugs Xuan Zhuo
2025-10-29 3:09 ` [PATCH net v4 1/4] virtio-net: fix incorrect flags recording in big mode Xuan Zhuo
2025-11-09 17:04 ` Alyssa Ross
2025-11-09 21:34 ` Michael S. Tsirkin
2025-10-29 3:09 ` [PATCH net v4 2/4] virtio-net: Ensure hdr_len is not set unless the header is forwarded to the device Xuan Zhuo
2025-10-30 2:42 ` Jason Wang
2025-11-09 21:37 ` Michael S. Tsirkin
2025-10-29 3:09 ` [PATCH net v4 3/4] virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN Xuan Zhuo
2025-10-30 2:53 ` Jason Wang
2025-11-09 21:41 ` Michael S. Tsirkin
2025-11-10 7:16 ` Jason Wang
2025-11-10 7:26 ` Michael S. Tsirkin
2025-11-10 7:39 ` Jason Wang
2025-11-10 16:10 ` Michael S. Tsirkin
2025-11-11 0:45 ` Jason Wang
2025-11-09 21:42 ` Michael S. Tsirkin
2025-10-29 3:09 ` [PATCH net v4 4/4] virtio-net: correct hdr_len handling for tunnel gso Xuan Zhuo
2025-10-29 9:51 ` Paolo Abeni
2025-10-30 8:02 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251030033025-mutt-send-email-mst@kernel.org \
--to=mst@redhat$(echo .)com \
--cc=alvaro.karsz@solid-run$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=eperezma@redhat$(echo .)com \
--cc=hengqi@linux$(echo .)alibaba.com \
--cc=jasowang@redhat$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=virtualization@lists$(echo .)linux.dev \
--cc=willemb@google$(echo .)com \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox