From: Jakub Kicinski <kuba@kernel•org>
To: Daniel Zahka <daniel.zahka@gmail•com>
Cc: Jiri Pirko <jiri@resnulli•us>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Simon Horman <horms@kernel•org>,
Jonathan Corbet <corbet@lwn•net>,
Srujana Challa <schalla@marvell•com>,
Bharat Bhushan <bbhushan2@marvell•com>,
Herbert Xu <herbert@gondor•apana.org.au>,
Brett Creeley <brett.creeley@amd•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
Michael Chan <michael.chan@broadcom•com>,
Pavan Chebbi <pavan.chebbi@broadcom•com>,
Tony Nguyen <anthony.l.nguyen@intel•com>,
Przemek Kitszel <przemyslaw.kitszel@intel•com>,
Sunil Goutham <sgoutham@marvell•com>,
Linu Cherian <lcherian@marvell•com>,
Geetha sowjanya <gakula@marvell•com>,
Jerin Jacob <jerinj@marvell•com>, hariprasad <hkelam@marvell•com>,
Subbaraya Sundeep <sbhatta@marvell•com>,
Tariq Toukan <tariqt@nvidia•com>,
Saeed Mahameed <saeedm@nvidia•com>,
Leon Romanovsky <leon@kernel•org>, Mark Bloch <mbloch@nvidia•com>,
Ido Schimmel <idosch@nvidia•com>, Petr Machata <petrm@nvidia•com>,
Manish Chopra <manishc@marvell•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Siddharth Vadapalli <s-vadapalli@ti•com>,
Roger Quadros <rogerq@kernel•org>,
Loic Poulain <loic.poulain@oss•qualcomm.com>,
Sergey Ryazanov <ryazanov.s.a@gmail•com>,
Johannes Berg <johannes@sipsolutions•net>,
Vladimir Oltean <olteanv@gmail•com>,
Michal Swiatkowski <michal.swiatkowski@linux•intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel•com>,
Dave Ertman <david.m.ertman@intel•com>,
Vlad Dumitrescu <vdumitrescu@nvidia•com>,
"Russell King (Oracle)" <rmk+kernel@armlinux•org.uk>,
Alexander Sverdlin <alexander.sverdlin@gmail•com>,
Lorenzo Bianconi <lorenzo@kernel•org>,
netdev@vger•kernel.org, linux-doc@vger•kernel.org,
intel-wired-lan@lists•osuosl.org, linux-rdma@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, linux-omap@vger•kernel.org
Subject: Re: [PATCH net-next v2 1/2] devlink: pass extack through to devlink_param::get()
Date: Mon, 3 Nov 2025 14:13:56 -0800 [thread overview]
Message-ID: <20251103141356.3470701b@kernel.org> (raw)
In-Reply-To: <20251103194554.3203178-2-daniel.zahka@gmail.com>
On Mon, 3 Nov 2025 11:45:52 -0800 Daniel Zahka wrote:
> Allow devlink_param::get() handlers to report error messages via
> extack. This function is called in a few different contexts, but not
> all of them will have an valid extack to use.
>
> When devlink_param::get() is called from param_get_doit or
> param_get_dumpit contexts, pass the extack through so that drivers can
> report errors when retrieving param values. devlink_param::get() is
> called from the context of devlink_param_notify(), pass NULL in for
> the extack.
Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:618 function parameter 'extack' not described in 'ice_devlink_tx_sched_layers_get'
Warning: drivers/net/ethernet/intel/ice/devlink/devlink.c:1533 function parameter 'extack' not described in 'ice_devlink_local_fwd_get'
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-03 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 19:45 [PATCH net-next v2 0/2] devlink: net/mlx5: implement swp_l4_csum_mode via devlink params Daniel Zahka
2025-11-03 19:45 ` [PATCH net-next v2 1/2] devlink: pass extack through to devlink_param::get() Daniel Zahka
2025-11-03 22:13 ` Jakub Kicinski [this message]
2025-11-04 17:13 ` kernel test robot
2025-11-03 19:45 ` [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params Daniel Zahka
2025-11-04 10:14 ` Jiri Pirko
2025-11-04 11:38 ` Daniel Zahka
2025-11-04 12:51 ` Daniel Zahka
2025-11-04 14:39 ` Jiri Pirko
2025-11-04 14:48 ` Daniel Zahka
2025-11-08 5:38 ` Saeed Mahameed
2025-11-09 10:37 ` Jiri Pirko
2025-11-04 19:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103141356.3470701b@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=aleksandr.loktionov@intel$(echo .)com \
--cc=alexander.sverdlin@gmail$(echo .)com \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anthony.l.nguyen@intel$(echo .)com \
--cc=bbhushan2@marvell$(echo .)com \
--cc=brett.creeley@amd$(echo .)com \
--cc=corbet@lwn$(echo .)net \
--cc=daniel.zahka@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=david.m.ertman@intel$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=gakula@marvell$(echo .)com \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=hkelam@marvell$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=intel-wired-lan@lists$(echo .)osuosl.org \
--cc=jerinj@marvell$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=johannes@sipsolutions$(echo .)net \
--cc=lcherian@marvell$(echo .)com \
--cc=leon@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=loic.poulain@oss$(echo .)qualcomm.com \
--cc=lorenzo@kernel$(echo .)org \
--cc=manishc@marvell$(echo .)com \
--cc=mbloch@nvidia$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=michal.swiatkowski@linux$(echo .)intel.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=olteanv@gmail$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=przemyslaw.kitszel@intel$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=rogerq@kernel$(echo .)org \
--cc=ryazanov.s.a@gmail$(echo .)com \
--cc=s-vadapalli@ti$(echo .)com \
--cc=saeedm@nvidia$(echo .)com \
--cc=sbhatta@marvell$(echo .)com \
--cc=schalla@marvell$(echo .)com \
--cc=sgoutham@marvell$(echo .)com \
--cc=tariqt@nvidia$(echo .)com \
--cc=vdumitrescu@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox