From: Jakub Kicinski <kuba@kernel•org>
To: Inochi Amaoto <inochiama@gmail•com>
Cc: Han Gao <rabenda.cn@gmail•com>, Icenowy Zheng <uwu@icenowy•me>,
Vivian Wang <wangruikang@iscas•ac.cn>, Yao Zi <ziyao@disroot•org>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Rob Herring <robh@kernel•org>,
Krzysztof Kozlowski <krzk+dt@kernel•org>,
Conor Dooley <conor+dt@kernel•org>,
Chen Wang <unicorn_wang@outlook•com>,
Maxime Coquelin <mcoquelin.stm32@gmail•com>,
Alexandre Torgue <alexandre.torgue@foss•st.com>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"Russell King (Oracle)" <rmk+kernel@armlinux•org.uk>,
netdev@vger•kernel.org, devicetree@vger•kernel.org,
sophgo@lists•linux.dev, linux-kernel@vger•kernel.org,
linux-stm32@st-md-mailman•stormreply.com,
linux-arm-kernel@lists•infradead.org, Yixun Lan <dlan@gentoo•org>,
Longbin Li <looong.bin@gmail•com>,
Maxime Chevallier <maxime.chevallier@bootlin•com>
Subject: Re: [PATCH v6 2/3] net: phy: Add helper for fixing RGMII PHY mode based on internal mac delay
Date: Mon, 3 Nov 2025 16:22:02 -0800 [thread overview]
Message-ID: <20251103162202.1bd0dae0@kernel.org> (raw)
In-Reply-To: <20251103030526.1092365-3-inochiama@gmail.com>
On Mon, 3 Nov 2025 11:05:25 +0800 Inochi Amaoto wrote:
> +/**
> + * phy_fix_phy_mode_for_mac_delays - Convenience function for fixing PHY
> + * mode based on whether mac adds internal delay
> + *
> + * @interface: The current interface mode of the port
> + * @mac_txid: True if the mac adds internal tx delay
> + * @mac_rxid: True if the mac adds internal rx delay
> + *
> + * Return fixed PHY mode, or PHY_INTERFACE_MODE_NA if the interface can
> + * not apply the internal delay
> + */
Please add a : after Return, so:
* Return: fixed PHY mode, or PHY_INTERFACE_MODE_NA if the interface can
otherwise kdoc warns:
Warning: drivers/net/phy/phy-core.c:116 No description found for return value of 'phy_fix_phy_mode_for_mac_delays'
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-04 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 3:05 [PATCH v6 0/3] net: stmmac: dwmac-sophgo: Add phy interface filter Inochi Amaoto
2025-11-03 3:05 ` [PATCH v6 1/3] dt-bindings: net: sophgo,sg2044-dwmac: add phy mode restriction Inochi Amaoto
2025-11-03 3:05 ` [PATCH v6 2/3] net: phy: Add helper for fixing RGMII PHY mode based on internal mac delay Inochi Amaoto
2025-11-04 0:22 ` Jakub Kicinski [this message]
2025-11-03 3:05 ` [PATCH v6 3/3] net: stmmac: dwmac-sophgo: Add phy interface filter Inochi Amaoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251103162202.1bd0dae0@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexandre.torgue@foss$(echo .)st.com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=conor+dt@kernel$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dlan@gentoo$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=inochiama@gmail$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-stm32@st-md-mailman$(echo .)stormreply.com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=looong.bin@gmail$(echo .)com \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mcoquelin.stm32@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=rabenda.cn@gmail$(echo .)com \
--cc=rmk+kernel@armlinux$(echo .)org.uk \
--cc=robh@kernel$(echo .)org \
--cc=sophgo@lists$(echo .)linux.dev \
--cc=unicorn_wang@outlook$(echo .)com \
--cc=uwu@icenowy$(echo .)me \
--cc=wangruikang@iscas$(echo .)ac.cn \
--cc=ziyao@disroot$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox