Subject: Re: [PATCH v6 2/3] net: phy: Add helper for fixing RGMII PHY mode based on internal mac delay

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Nov 2025 16:22:02 -0800

On Mon,  3 Nov 2025 11:05:25 +0800 Inochi Amaoto wrote:
> +/**
> + * phy_fix_phy_mode_for_mac_delays - Convenience function for fixing PHY
> + * mode based on whether mac adds internal delay
> + *
> + * @interface: The current interface mode of the port
> + * @mac_txid: True if the mac adds internal tx delay
> + * @mac_rxid: True if the mac adds internal rx delay
> + *
> + * Return fixed PHY mode, or PHY_INTERFACE_MODE_NA if the interface can
> + * not apply the internal delay
> + */

Please add a : after Return, so:

 * Return: fixed PHY mode, or PHY_INTERFACE_MODE_NA if the interface can

otherwise kdoc warns:

Warning: drivers/net/phy/phy-core.c:116 No description found for return value of 'phy_fix_phy_mode_for_mac_delays'
-- 
pw-bot: cr