Subject: Re: [PATCH] net/core/sock: fix coding style issues Fix multiple coding style issues in net/core/sock.c:

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Nov 2025 17:26:37 -0800

On Mon,  3 Nov 2025 10:36:53 +0800 XueBing Chen wrote:
> - Remove spaces before commas in _sock_locks macro definition
> - Use tabs instead of spaces for macro line continuation indentation
> - Separate assignment from if condition in __sk_receive_skb function
> - Fix pointer declaration format in timer functions
> - Add spaces around == operator in preprocessor directive
> 
> These changes improve code style compliance with kernel coding standards
> without affecting functionality.

Quoting documentation:

  Clean-up patches
  ~~~~~~~~~~~~~~~~
  
  Netdev discourages patches which perform simple clean-ups, which are not in
  the context of other work. For example:
  
  * Addressing ``checkpatch.pl``, and other trivial coding style warnings
  * Addressing :ref:`Local variable ordering<rcs>` issues
  * Conversions to device-managed APIs (``devm_`` helpers)
  
  This is because it is felt that the churn that such changes produce comes
  at a greater cost than the value of such clean-ups.
  
  Conversely, spelling and grammar fixes are not discouraged.
  
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#clean-up-patches
-- 
pw-bot: reject