Subject: Re: [PATCH net-next v9 1/5] eea: introduce PCI framework

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Nov 2025 18:23:30 -0800

On Wed, 29 Oct 2025 16:01:41 +0800 Xuan Zhuo wrote:
> +static int __eea_pci_probe(struct pci_dev *pci_dev,
> +			   struct eea_pci_device *ep_dev)
> +{
> +	int err;
> +
> +	pci_set_drvdata(pci_dev, ep_dev);
> +
> +	err = eea_pci_setup(pci_dev, ep_dev);
> +	if (err)
> +		goto err_setup;
> +
> +	err = eea_init_device(&ep_dev->edev);
> +	if (err)
> +		goto err_register;
> +
> +	return 0;
> +
> +err_register:
> +	eea_pci_release_resource(ep_dev);
> +
> +err_setup:
> +	kfree(ep_dev);
> +	return err;

Please name the jump labels after the target (usually first action they
perform).
-- 
pw-bot: cr