Subject: Re: [PATCH net-next v04 0/5] net: hinic3: PF initialization

From: Jakub Kicinski <[email-masked]>
Date: Mon, 3 Nov 2025 18:29:09 -0800

On Wed, 29 Oct 2025 14:16:24 +0800 Fan Gong wrote:
> This is [1/3] part of hinic3 Ethernet driver second submission.
> With this patch hinic3 becomes a complete Ethernet driver with
> pf and vf.
> 
> The driver parts contained in this patch:
> Add support for PF framework based on the VF code.
> Add PF management interfaces to communicate with HW.
> Add ops to configure NIC features.
> Support mac filter to unicast and multicast.
> Add netdev notifier.

Please try to wrap the code at 80 characters.
checkpatch --max-line-length=80
almost all the violations in this series can be easily fixed.

For function definitions you can put the return type on separate line:

static struct hinic3_mac_filter *
hinic3_mac_filter_entry_clone(const struct hinic3_mac_filter *src)
-- 
pw-bot: cr