Subject: Re: [PATCH net-next v2 2/2] net/mlx5: implement swp_l4_csum_mode via devlink params

From: Jakub Kicinski <[email-masked]>
Date: Tue, 4 Nov 2025 11:22:14 -0800

On Tue, 4 Nov 2025 11:14:03 +0100 Jiri Pirko wrote:
> >@@ -548,6 +703,12 @@ static const struct devlink_param mlx5_nv_param_devlink_params[] = {
> > 			     mlx5_nv_param_devlink_cqe_compress_get,
> > 			     mlx5_nv_param_devlink_cqe_compress_set,
> > 			     mlx5_nv_param_devlink_cqe_compress_validate),
> >+	DEVLINK_PARAM_DRIVER(MLX5_DEVLINK_PARAM_ID_SWP_L4_CSUM_MODE,
> >+			     "swp_l4_csum_mode", DEVLINK_PARAM_TYPE_STRING,  
> 
> I still think that even unlikely this will be implemented in other
> driver, it is generic param. Could you please treat it as such?

We need a clearer definition of what this does then.

Is it basically disabling silicon validation of L4 checksum and allows
for the FW to compute the L4 checksum? Which may negatively impact
performance? (hence disabled by default?)