Subject: Re: [PATCH v3] net: wan: framer: pef2256: Switch to devm_mfd_add_devices()

From: Herve Codina <[email-masked]>
Date: Wed, 5 Nov 2025 08:34:08 +0100

Hi Haotian,

On Wed,  5 Nov 2025 11:47:16 +0800
Haotian Zhang <[email-masked]> wrote:

> The driver calls mfd_add_devices() but fails to call mfd_remove_devices()
> in error paths after successful MFD device registration and in the remove
> function. This leads to resource leaks where MFD child devices are not
> properly unregistered.
> 
> Replace mfd_add_devices with devm_mfd_add_devices to automatically
> manage the device resources.
> 
> Fixes: c96e976d9a05 ("net: wan: framer: Add support for the Lantiq PEF2256 framer")
> Suggested-by: Herve Codina <[email-masked]>
> Suggested-by: Jakub Kicinski <[email-masked]>
> Signed-off-by: Haotian Zhang <[email-masked]>

Not sure that 'Suggested-by: Jakub Kicinski' was needed according to his
comments on v2. Also, you forgot my 'Acked-by' I sent on v2.

Anyway, the v3 is ok on my side

Acked-by: Herve Codina <[email-masked]>

Best regards,
Hervé