From: Jakub Kicinski <kuba@kernel•org>
To: Buday Csaba <buday.csaba@prolan•hu>
Cc: Andrew Lunn <andrew@lunn•ch>,
Heiner Kallweit <hkallweit1@gmail•com>,
Russell King <linux@armlinux•org.uk>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Philipp Zabel <p.zabel@pengutronix•de>, <netdev@vger•kernel.org>,
<linux-kernel@vger•kernel.org>
Subject: Re: [PATCH net-next 3/3] net: mdio: improve reset handling in mdio_device.c
Date: Thu, 6 Nov 2025 14:46:03 -0800 [thread overview]
Message-ID: <20251106144603.39053c81@kernel.org> (raw)
In-Reply-To: <11b197641e5498cab3e43f8983120fcabe06257e.1761909948.git.buday.csaba@prolan.hu>
On Fri, 31 Oct 2025 12:32:28 +0100 Buday Csaba wrote:
> reset = reset_control_get_optional_exclusive(&mdiodev->dev, "phy");
> - if (IS_ERR(reset))
> + if (IS_ERR(reset)) {
> + gpiod_put(mdiodev->reset_gpio);
> + mdiodev->reset_gpio = NULL;
> return PTR_ERR(reset);
> + }
We usually consider all sort of leaks as real fixes.
Let's fix this in mdiobus_register_device() in net/main first?
Then do the refactoring once net merges into net-next (every Thu)?
--
pw-bot: cr
prev parent reply other threads:[~2025-11-06 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 11:32 [PATCH net-next 0/3] net: mdio: improve reset handling of mdio devices Buday Csaba
2025-10-31 11:32 ` [PATCH net-next 1/3] net: mdio: move device reset functions to mdio_device.c Buday Csaba
2025-10-31 11:32 ` [PATCH net-next 2/3] net: mdio: common handling of phy device reset properties Buday Csaba
2025-10-31 11:32 ` [PATCH net-next 3/3] net: mdio: improve reset handling in mdio_device.c Buday Csaba
2025-11-06 22:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251106144603.39053c81@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=buday.csaba@prolan$(echo .)hu \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=p.zabel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox