From: Jakub Kicinski <kuba@kernel•org>
To: Jacob Keller <jacob.e.keller@intel•com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Manish Chopra <manishc@marvell•com>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Richard Cochran <richardcochran@gmail•com>,
Simon Horman <horms@kernel•org>,
Kory Maincent <kory.maincent@bootlin•com>,
<netdev@vger•kernel.org>
Subject: Re: [PATCH net-next v2 1/2] bnx2x: convert to use ndo_hwtstamp callbacks
Date: Mon, 10 Nov 2025 15:50:24 -0800 [thread overview]
Message-ID: <20251110155024.0436b087@kernel.org> (raw)
In-Reply-To: <8a91d75b-3ba7-47be-9176-5d2245ac4fd5@intel.com>
On Mon, 10 Nov 2025 15:23:23 -0800 Jacob Keller wrote:
> On 11/8/2025 4:38 AM, Vadim Fedorenko wrote:
> > On 08/11/2025 02:41, Jakub Kicinski wrote:
> >> On Thu, 6 Nov 2025 21:37:16 +0000 Vadim Fedorenko wrote:
> >> This is the wrong way around, if someone adds a new value unsupported
> >> by the driver it will pass. We should be listing the supported types
> >> and
> >>
> >> default:
> >> ...ERR_MSG..
> >> return -ERANGE;
> >> }
> >
> > But that's the original logic of the driver. Should I change it within
> > the same patch, or is it better to make a follow-up work to clean such
> > things in net-next?
That's partially true, note that the original code did not have a
default clause. So (IIUC) compiler would warn us if we added a new
enum value without adding it in this driver. You're adding defaults.
> I'd prefer a separate patch for clarity. A backport is probably
> unnecessary since I doubt we'll add a new timestamp mode in such a
> backport in the future.. but functional changes like that make sense as
> a separate patch.
Yup, I think I asked for separate patch originally. Perhpas I wasn't
clear enough.
next prev parent reply other threads:[~2025-11-10 23:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 21:37 [PATCH net-next v2 0/2] convert drivers to use ndo_hwtstamp callbacks part 4 Vadim Fedorenko
2025-11-06 21:37 ` [PATCH net-next v2 1/2] bnx2x: convert to use ndo_hwtstamp callbacks Vadim Fedorenko
2025-11-08 2:41 ` Jakub Kicinski
2025-11-08 12:38 ` Vadim Fedorenko
2025-11-10 23:23 ` Jacob Keller
2025-11-10 23:50 ` Jakub Kicinski [this message]
2025-11-06 21:37 ` [PATCH net-next v2 2/2] qede: " Vadim Fedorenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110155024.0436b087@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=manishc@marvell$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=richardcochran@gmail$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox