Subject: Re: [PATCH v20 06/22] cxl: Move pci generic code

From: Jonathan Cameron <[email-masked]>
Date: Wed, 12 Nov 2025 15:41:03 +0000

On Mon, 10 Nov 2025 15:36:41 +0000
[email-masked] wrote:

> From: Alejandro Lucero <[email-masked]>
> 
> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
> meanwhile cxl/pci.c implements the functionality for a Type3 device
> initialization.
> 
> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
> exported and shared with CXL Type2 device initialization.
> 
> Fix cxl mock tests affected by the code move, deleting a function which
> indeed was not being used since commit 733b57f262b0("cxl/pci: Early
> setup RCH dport component registers from RCRB").

As I replied late to v19, I'd like to understand more about this comment.
If it was not being used, why can't we remove it before this patch?

> 
> Signed-off-by: Alejandro Lucero <[email-masked]>
> Reviewed-by: Dave Jiang <[email-masked]>
> Reviewed-by: Ben Cheatham <[email-masked]>
> Reviewed-by: Fan Ni <[email-masked]>
> Reviewed-by: Jonathan Cameron <[email-masked]>
> Reviewed-by: Alison Schofield <[email-masked]>
> Reviewed-by: Dan Williams <[email-masked]>