From: Jakub Kicinski <kuba@kernel•org>
To: davem@davemloft•net
Cc: netdev@vger•kernel.org, edumazet@google•com, pabeni@redhat•com,
andrew+netdev@lunn•ch, horms@kernel•org,
willemdebruijn.kernel@gmail•com, shuah@kernel•org,
sdf@fomichev•me, krakauer@google•com,
linux-kselftest@vger•kernel.org, petrm@nvidia•com,
matttbe@kernel•org, Jakub Kicinski <kuba@kernel•org>
Subject: [PATCH net-next v2 08/12] netdevsim: pass packets thru GRO on Rx
Date: Tue, 18 Nov 2025 13:51:22 -0800 [thread overview]
Message-ID: <20251118215126.2225826-9-kuba@kernel.org> (raw)
In-Reply-To: <20251118215126.2225826-1-kuba@kernel.org>
To replace veth in software GRO testing with netdevsim we need
GRO support in netdevsim. Luckily we already have NAPI support
so this change is trivial (compared to veth).
Signed-off-by: Jakub Kicinski <kuba@kernel•org>
---
v2:
- fix typo "compared"
v1: https://lore.kernel.org/20251117205810.1617533-9-kuba@kernel.org
---
drivers/net/netdevsim/netdev.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/netdevsim/netdev.c b/drivers/net/netdevsim/netdev.c
index fa1d97885caa..2b713db16cd0 100644
--- a/drivers/net/netdevsim/netdev.c
+++ b/drivers/net/netdevsim/netdev.c
@@ -433,13 +433,8 @@ static int nsim_rcv(struct nsim_rq *rq, int budget)
}
/* skb might be discard at netif_receive_skb, save the len */
- skblen = skb->len;
- skb_mark_napi_id(skb, &rq->napi);
- ret = netif_receive_skb(skb);
- if (ret == NET_RX_SUCCESS)
- dev_dstats_rx_add(dev, skblen);
- else
- dev_dstats_rx_dropped(dev);
+ dev_dstats_rx_add(dev, skb->len);
+ napi_gro_receive(&rq->napi, skb);
}
nsim_start_peer_tx_queue(dev, rq);
--
2.51.1
next prev parent reply other threads:[~2025-11-18 21:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 21:51 [PATCH net-next v2 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Jakub Kicinski
2025-11-18 21:51 ` [PATCH net-next v2 01/12] selftests: net: py: coding style improvements Jakub Kicinski
2025-11-19 13:40 ` Petr Machata
2025-11-19 14:32 ` Jakub Kicinski
2025-11-19 16:06 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 02/12] selftests: net: py: extract the case generation logic Jakub Kicinski
2025-11-19 14:11 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 03/12] selftests: net: py: add test variants Jakub Kicinski
2025-11-19 14:42 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 04/12] selftests: drv-net: xdp: use variants for qstat tests Jakub Kicinski
2025-11-19 14:57 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 05/12] selftests: net: relocate gro and toeplitz tests to drivers/net Jakub Kicinski
2025-11-19 15:09 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 06/12] selftests: net: py: support ksft ready without wait Jakub Kicinski
2025-11-19 16:31 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 07/12] selftests: net: py: read ip link info about remote dev Jakub Kicinski
2025-11-19 15:33 ` Petr Machata
2025-11-18 21:51 ` Jakub Kicinski [this message]
2025-11-19 15:43 ` [PATCH net-next v2 08/12] netdevsim: pass packets thru GRO on Rx Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 09/12] selftests: drv-net: add a Python version of the GRO test Jakub Kicinski
2025-11-19 15:54 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 10/12] selftests: drv-net: hw: convert the Toeplitz test to Python Jakub Kicinski
2025-11-19 16:39 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 11/12] netdevsim: add loopback support Jakub Kicinski
2025-11-19 17:01 ` Petr Machata
2025-11-18 21:51 ` [PATCH net-next v2 12/12] selftests: net: remove old setup_* scripts Jakub Kicinski
2025-11-19 17:04 ` Petr Machata
2025-11-18 22:31 ` [PATCH net-next v2 00/12] selftests: drv-net: convert GRO and Toeplitz tests to work for drivers in NIPA Willem de Bruijn
2025-11-19 0:25 ` Jakub Kicinski
2025-11-19 0:32 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251118215126.2225826-9-kuba@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=krakauer@google$(echo .)com \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=matttbe@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=petrm@nvidia$(echo .)com \
--cc=sdf@fomichev$(echo .)me \
--cc=shuah@kernel$(echo .)org \
--cc=willemdebruijn.kernel@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox