Subject: Re: [PATCH net-next v11 11/12] virtio_net: Add support for TCP and UDP ethtool rules

From: "Michael S. Tsirkin" <[email-masked]>
Date: Wed, 19 Nov 2025 04:14:57 -0500

On Tue, Nov 18, 2025 at 08:39:01AM -0600, Daniel Jurgens wrote:
> @@ -7167,6 +7261,10 @@ static bool supported_flow_type(const struct ethtool_rx_flow_spec *fs)
>  	case ETHER_FLOW:
>  	case IP_USER_FLOW:
>  	case IPV6_USER_FLOW:
> +	case TCP_V4_FLOW:
> +	case TCP_V6_FLOW:
> +	case UDP_V4_FLOW:
> +	case UDP_V6_FLOW:
>  		return true;
>  	}
>  

it kinda looks like you are sending flow control rules to
the device ignoring what it reported as supported through
VIRTIO_NET_FF_SELECTOR_CAP

Is that right?

The spec does not say what happens in such a case.

Parav what is your take? is the implication that driver
must only send supported rules?

-- 
MST