From: Jakub Kicinski <kuba@kernel•org>
To: Maxime Chevallier <maxime.chevallier@bootlin•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-arm-msm@vger•kernel.org,
thomas.petazzoni@bootlin•com, "Andrew Lunn" <andrew@lunn•ch>,
"Eric Dumazet" <edumazet@google•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Russell King" <linux@armlinux•org.uk>,
linux-arm-kernel@lists•infradead.org,
"Christophe Leroy" <christophe.leroy@csgroup•eu>,
"Herve Codina" <herve.codina@bootlin•com>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Heiner Kallweit" <hkallweit1@gmail•com>,
"Vladimir Oltean" <vladimir.oltean@nxp•com>,
"Köry Maincent" <kory.maincent@bootlin•com>,
"Marek Behún" <kabel@kernel•org>,
"Oleksij Rempel" <o.rempel@pengutronix•de>,
"Nicolò Veronese" <nicveronese@gmail•com>,
"Simon Horman" <horms@kernel•org>,
mwojtas@chromium•org, "Antoine Tenart" <atenart@kernel•org>,
devicetree@vger•kernel.org, "Conor Dooley" <conor+dt@kernel•org>,
"Krzysztof Kozlowski" <krzk+dt@kernel•org>,
"Rob Herring" <robh@kernel•org>,
"Romain Gantois" <romain.gantois@bootlin•com>,
"Daniel Golle" <daniel@makrotopia•org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr•com>
Subject: Re: [PATCH net-next v17 03/15] net: phy: Introduce PHY ports representation
Date: Wed, 19 Nov 2025 19:54:00 -0800 [thread overview]
Message-ID: <20251119195400.1bf0cc68@kernel.org> (raw)
In-Reply-To: <20251119195920.442860-4-maxime.chevallier@bootlin.com>
On Wed, 19 Nov 2025 20:59:04 +0100 Maxime Chevallier wrote:
> diff --git a/net/ethtool/common.c b/net/ethtool/common.c
> index 2f4b70f104e8..8216e4ada58e 100644
> --- a/net/ethtool/common.c
> +++ b/net/ethtool/common.c
> @@ -460,6 +460,21 @@ const struct link_mode_info link_mode_params[] = {
> static_assert(ARRAY_SIZE(link_mode_params) == __ETHTOOL_LINK_MODE_MASK_NBITS);
> EXPORT_SYMBOL_GPL(link_mode_params);
>
> +const char ethtool_link_medium_names[][ETH_GSTRING_LEN] = {
> + [ETHTOOL_LINK_MEDIUM_BASET] = "BaseT",
> + [ETHTOOL_LINK_MEDIUM_BASEK] = "BaseK",
> + [ETHTOOL_LINK_MEDIUM_BASES] = "BaseS",
> + [ETHTOOL_LINK_MEDIUM_BASEC] = "BaseC",
> + [ETHTOOL_LINK_MEDIUM_BASEL] = "BaseL",
> + [ETHTOOL_LINK_MEDIUM_BASED] = "BaseD",
> + [ETHTOOL_LINK_MEDIUM_BASEE] = "BaseE",
> + [ETHTOOL_LINK_MEDIUM_BASEF] = "BaseF",
> + [ETHTOOL_LINK_MEDIUM_BASEV] = "BaseV",
> + [ETHTOOL_LINK_MEDIUM_BASEMLD] = "BaseMLD",
> + [ETHTOOL_LINK_MEDIUM_NONE] = "None",
> +};
> +static_assert(ARRAY_SIZE(ethtool_link_medium_names) == __ETHTOOL_LINK_MEDIUM_LAST);
Thanks for reshuffling things, this one needs a static tho:
net/ethtool/common.c:463:12: warning: symbol 'ethtool_link_medium_names' was not declared. Should it be static?
--
pw-bot: cr
next prev parent reply other threads:[~2025-11-20 3:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-19 19:59 [PATCH net-next v17 00/15] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 01/15] dt-bindings: net: Introduce the ethernet-connector description Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 02/15] net: ethtool: Introduce ETHTOOL_LINK_MEDIUM_* values Maxime Chevallier
2025-11-20 6:28 ` Christophe Leroy
2025-11-19 19:59 ` [PATCH net-next v17 03/15] net: phy: Introduce PHY ports representation Maxime Chevallier
2025-11-20 3:54 ` Jakub Kicinski [this message]
2025-11-20 8:14 ` Maxime Chevallier
2025-11-20 15:18 ` Maxime Chevallier
2025-11-20 6:30 ` Christophe Leroy
2025-11-20 19:48 ` kernel test robot
2025-11-19 19:59 ` [PATCH net-next v17 04/15] net: phy: dp83822: Add support for phy_port representation Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 05/15] dt-bindings: net: dp83822: Deprecate ti,fiber-mode Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 06/15] net: phy: Create a phy_port for PHY-driven SFPs Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 07/15] net: phy: Introduce generic SFP handling for PHY drivers Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 08/15] net: phy: marvell-88x2222: Support SFP through phy_port interface Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 09/15] net: phy: marvell: " Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 10/15] net: phy: marvell10g: Support SFP through phy_port Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 11/15] net: phy: at803x: Support SFP through phy_port interface Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 12/15] net: phy: qca807x: " Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 13/15] net: phy: Only rely on phy_port for PHY-driven SFP Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 14/15] net: phy: dp83822: Add SFP support through the phy_port interface Maxime Chevallier
2025-11-19 19:59 ` [PATCH net-next v17 15/15] Documentation: networking: Document the phy_port infrastructure Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251119195400.1bf0cc68@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew@lunn$(echo .)ch \
--cc=atenart@kernel$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=conor+dt@kernel$(echo .)org \
--cc=daniel@makrotopia$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dimitri.fedrau@liebherr$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=herve.codina@bootlin$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=kabel@kernel$(echo .)org \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=krzk+dt@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=maxime.chevallier@bootlin$(echo .)com \
--cc=mwojtas@chromium$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nicveronese@gmail$(echo .)com \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=romain.gantois@bootlin$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=vladimir.oltean@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox