From: Jakub Kicinski <kuba@kernel•org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby•net>
Cc: "Donald Hunter" <donald.hunter@gmail•com>,
"Jason A. Donenfeld" <Jason@zx2c4•com>,
"Andrew Lunn" <andrew+netdev@lunn•ch>,
"Anna Schumaker" <anna@kernel•org>,
"Antonio Quartulli" <antonio@openvpn•net>,
"Arkadiusz Kubalewski" <arkadiusz.kubalewski@intel•com>,
"Arve Hjønnevåg" <arve@android•com>,
"Carlos Llamas" <cmllamas@google•com>,
"Christian Brauner" <brauner@kernel•org>,
"Chuck Lever" <chuck.lever@oracle•com>,
"Dai Ngo" <Dai.Ngo@oracle•com>,
"Daniel Zahka" <daniel.zahka@gmail•com>,
"David Ahern" <dsahern@kernel•org>,
"David S. Miller" <davem@davemloft•net>,
"David Wei" <dw@davidwei•uk>,
"Eric Dumazet" <edumazet@google•com>,
"Geliang Tang" <geliang@kernel•org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Hannes Reinecke" <hare@kernel•org>,
"Jacob Keller" <jacob.e.keller@intel•com>,
"Jeff Layton" <jlayton@kernel•org>,
"Jiri Pirko" <jiri@resnulli•us>,
"Joe Damato" <jdamato@fastly•com>,
"Joel Fernandes" <joelagnelf@nvidia•com>,
kernel-tls-handshake@lists•linux.dev, "Li Li" <dualli@google•com>,
linux-kernel@vger•kernel.org, linux-nfs@vger•kernel.org,
"Martijn Coenen" <maco@android•com>,
"Mat Martineau" <martineau@kernel•org>,
"Matthieu Baerts" <matttbe@kernel•org>,
"Mina Almasry" <almasrymina@google•com>,
mptcp@lists•linux.dev, NeilBrown <neil@brown•name>,
netdev@vger•kernel.org, "Olga Kornievskaia" <okorniev@redhat•com>,
"Paolo Abeni" <pabeni@redhat•com>,
"Sabrina Dubroca" <sd@queasysnail•net>,
"Samiullah Khawaja" <skhawaja@google•com>,
"Simon Horman" <horms@kernel•org>,
"Stanislav Fomichev" <sdf@fomichev•me>,
"Suren Baghdasaryan" <surenb@google•com>,
"Todd Kjos" <tkjos@android•com>, "Tom Talpey" <tom@talpey•com>,
"Trond Myklebust" <trondmy@kernel•org>,
"Vadim Fedorenko" <vadim.fedorenko@linux•dev>,
"Willem de Bruijn" <willemb@google•com>
Subject: Re: [PATCH net-next 2/2] tools: ynl-gen: add regeneration comment
Date: Thu, 20 Nov 2025 17:48:29 -0800 [thread overview]
Message-ID: <20251120174829.2e9c44a7@kernel.org> (raw)
In-Reply-To: <20251120100240.1e80c65f@kernel.org>
On Thu, 20 Nov 2025 10:02:40 -0800 Jakub Kicinski wrote:
> On Thu, 20 Nov 2025 17:44:27 +0000 Asbjørn Sloth Tønnesen wrote:
> > Add a comment on regeneration to the generated files.
> >
> > The comment is placed after the YNL-GEN line[1], as to not interfere
> > with ynl-regen.sh's detection logic.
> >
> > [1] and after the optional YNL-ARG line.
>
> Let's make this comment also optional? Detect whether it's there
> in the bash script and pass appropriate flag to C gen?
Raced responding with Matthieu. Sounds like a strong signal that this
is useful, so let's keep the patch as is. I'll revive it in pw.
next prev parent reply other threads:[~2025-11-21 1:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 17:44 [PATCH net-next 0/2] tools: ynl-gen: regeneration comment + function prefix Asbjørn Sloth Tønnesen
2025-11-20 17:44 ` [PATCH net-next 1/2] tools: ynl-gen: add function prefix argument Asbjørn Sloth Tønnesen
2025-11-20 17:44 ` [PATCH net-next 2/2] tools: ynl-gen: add regeneration comment Asbjørn Sloth Tønnesen
2025-11-20 17:56 ` Matthieu Baerts
2025-11-20 18:02 ` Jakub Kicinski
2025-11-21 1:48 ` Jakub Kicinski [this message]
2025-11-26 4:00 ` [PATCH net-next 0/2] tools: ynl-gen: regeneration comment + function prefix patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251120174829.2e9c44a7@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=Dai.Ngo@oracle$(echo .)com \
--cc=Jason@zx2c4$(echo .)com \
--cc=almasrymina@google$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=anna@kernel$(echo .)org \
--cc=antonio@openvpn$(echo .)net \
--cc=arkadiusz.kubalewski@intel$(echo .)com \
--cc=arve@android$(echo .)com \
--cc=ast@fiberby$(echo .)net \
--cc=brauner@kernel$(echo .)org \
--cc=chuck.lever@oracle$(echo .)com \
--cc=cmllamas@google$(echo .)com \
--cc=daniel.zahka@gmail$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=dsahern@kernel$(echo .)org \
--cc=dualli@google$(echo .)com \
--cc=dw@davidwei$(echo .)uk \
--cc=edumazet@google$(echo .)com \
--cc=geliang@kernel$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hare@kernel$(echo .)org \
--cc=horms@kernel$(echo .)org \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=jdamato@fastly$(echo .)com \
--cc=jiri@resnulli$(echo .)us \
--cc=jlayton@kernel$(echo .)org \
--cc=joelagnelf@nvidia$(echo .)com \
--cc=kernel-tls-handshake@lists$(echo .)linux.dev \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-nfs@vger$(echo .)kernel.org \
--cc=maco@android$(echo .)com \
--cc=martineau@kernel$(echo .)org \
--cc=matttbe@kernel$(echo .)org \
--cc=mptcp@lists$(echo .)linux.dev \
--cc=neil@brown$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=okorniev@redhat$(echo .)com \
--cc=pabeni@redhat$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
--cc=sdf@fomichev$(echo .)me \
--cc=skhawaja@google$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=tkjos@android$(echo .)com \
--cc=tom@talpey$(echo .)com \
--cc=trondmy@kernel$(echo .)org \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=willemb@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox