Subject: Re: [PATCH net-next, 1/2] net: mana: Add support for coalesced RX packets on CQE

From: Jakub Kicinski <[email-masked]>
Date: Fri, 2 Jan 2026 16:11:47 -0800

On Fri,  2 Jan 2026 13:35:57 -0800 Haiyang Zhang wrote:
> +		NL_SET_ERR_MSG_FMT(extack, "Set rx-frames to %u failed:%d\n",
> +				   ec->rx_max_coalesced_frames, err);

No trailing new line in extack messages, please.
Also please do not duplicate the err value in the message itself,
it's already passed to user space. Well behaved user space will format
this as eg:

  Set rx-frames to 123 failed:-11: Invalid argument
-- 
pw-bot: cr