From: Jakub Kicinski <kuba@kernel•org>
To: Joris Vaisvila <joey@tinyisr•com>
Cc: netdev@vger•kernel.org, nbd@nbd•name, sean.wang@mediatek•com,
lorenzo@kernel•org, andrew+netdev@lunn•ch, davem@davemloft•net,
edumazet@google•com, pabeni@redhat•com
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: avoid writing to ESW registers on MT7628
Date: Sun, 4 Jan 2026 08:10:44 -0800 [thread overview]
Message-ID: <20260104081044.66dbc237@kernel.org> (raw)
In-Reply-To: <20251230091151.129176-1-joey@tinyisr.com>
On Tue, 30 Dec 2025 11:10:41 +0200 Joris Vaisvila wrote:
> The MT7628 does not expose MAC control registers. Writes to these
> registers corrupt the ESW VLAN configuration. Existing drivers
> never use the affected features, so this went unnoticed.
>
> This patch skips MCR register reads and writes on MT7628, preventing
> invalid register access.
please add a suitable Fixes tag and repost
--
pw-bot: cr
prev parent reply other threads:[~2026-01-04 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-30 9:10 [PATCH] net: ethernet: mtk_eth_soc: avoid writing to ESW registers on MT7628 Joris Vaisvila
2026-01-04 16:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104081044.66dbc237@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=joey@tinyisr$(echo .)com \
--cc=lorenzo@kernel$(echo .)org \
--cc=nbd@nbd$(echo .)name \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sean.wang@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox