From: Yeounsu Moon <yyyynoom@gmail•com>
To: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>
Cc: netdev@vger•kernel.org, linux-kernel@vger•kernel.org,
Yeounsu Moon <yyyynoom@gmail•com>
Subject: [PATCH net-next] net: dlink: replace printk() with netdev_info() in rio_probe1()
Date: Sun, 4 Jan 2026 20:18:50 +0900 [thread overview]
Message-ID: <20260104111849.10790-2-yyyynoom@gmail.com> (raw)
Replace rio_probe1() printk(KERN_INFO) messages with netdev_info().
Log rx_timeout on a separate line since netdev_info() prefixes each
message and the multi-line formatting looks broken otherwise.
No functional change intended.
Tested-on: D-Link DGE 550T Rev-A3
Signed-off-by: Yeounsu Moon <yyyynoom@gmail•com>
---
drivers/net/ethernet/dlink/dl2k.c | 17 +++++++----------
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/dlink/dl2k.c b/drivers/net/ethernet/dlink/dl2k.c
index 846d58c769ea..b2af6399c3e8 100644
--- a/drivers/net/ethernet/dlink/dl2k.c
+++ b/drivers/net/ethernet/dlink/dl2k.c
@@ -279,18 +279,15 @@ rio_probe1 (struct pci_dev *pdev, const struct pci_device_id *ent)
card_idx++;
- printk (KERN_INFO "%s: %s, %pM, IRQ %d\n",
- dev->name, np->name, dev->dev_addr, irq);
+ netdev_info(dev, "%s, %pM, IRQ %d", np->name, dev->dev_addr, irq);
if (tx_coalesce > 1)
- printk(KERN_INFO "tx_coalesce:\t%d packets\n",
- tx_coalesce);
- if (np->coalesce)
- printk(KERN_INFO
- "rx_coalesce:\t%d packets\n"
- "rx_timeout: \t%d ns\n",
- np->rx_coalesce, np->rx_timeout*640);
+ netdev_info(dev, "tx_coalesce:\t%d packets", tx_coalesce);
+ if (np->coalesce) {
+ netdev_info(dev, "rx_coalesce:\t%d packets", np->rx_coalesce);
+ netdev_info(dev, "rx_timeout: \t%d ns", np->rx_timeout * 640);
+ }
if (np->vlan)
- printk(KERN_INFO "vlan(id):\t%d\n", np->vlan);
+ netdev_info(dev, "vlan(id):\t%d", np->vlan);
return 0;
err_out_unmap_rx:
--
2.52.0
next reply other threads:[~2026-01-04 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-04 11:18 Yeounsu Moon [this message]
2026-01-04 22:06 ` [PATCH net-next] net: dlink: replace printk() with netdev_info() in rio_probe1() Andrew Lunn
2026-01-05 11:03 ` Yeounsu Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260104111849.10790-2-yyyynoom@gmail.com \
--to=yyyynoom@gmail$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kuba@kernel$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox