From: Jakub Kicinski <kuba@kernel•org>
To: Cosmin Ratiu <cratiu@nvidia•com>
Cc: <netdev@vger•kernel.org>, Sabrina Dubroca <sd@queasysnail•net>,
Andrew Lunn <andrew+netdev@lunn•ch>,
"David S . Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>,
Dragos Tatulea <dtatulea@nvidia•com>
Subject: Re: [PATCH net-next] macsec: Support VLAN-filtering lower devices
Date: Tue, 6 Jan 2026 17:10:27 -0800 [thread overview]
Message-ID: <20260106171027.57a7757f@kernel.org> (raw)
In-Reply-To: <20260105101858.2627743-1-cratiu@nvidia.com>
On Mon, 5 Jan 2026 12:18:58 +0200 Cosmin Ratiu wrote:
> Before commit [1] this used to accidentally work because the macsec
> device (and thus the lower device) was put in promiscuous mode and the
> VLAN filter was not used. But after commit [1] correctly made the macsec
> driver expose the IFF_UNICAST_FLT flag, promiscuous mode was no longer
> used and VLAN filters on dev 1 kicked in. Without support in dev 2 for
> propagating VLAN filters down, the register_vlan_dev -> vlan_vid_add ->
> __vlan_vid_add -> vlan_add_rx_filter_info call from dev 3 is silently
> eaten (because vlan_hw_filter_capable returns false and
> vlan_add_rx_filter_info silently succeeds).
>
> [1] commit 0349659fd72f ("macsec: set IFF_UNICAST_FLT priv flag")
It used to work and now it doesn't sounds like a description of a fix.
Whether the working state was by design or accidental doesn't really
matter, I think? Please explain or resend for net with a Fixes..
--
pw-bot: cr
prev parent reply other threads:[~2026-01-07 1:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 10:18 [PATCH net-next] macsec: Support VLAN-filtering lower devices Cosmin Ratiu
2026-01-07 1:10 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106171027.57a7757f@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=cratiu@nvidia$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dtatulea@nvidia$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=sd@queasysnail$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox