From: Jakub Kicinski <kuba@kernel•org>
To: Michael Chan <michael.chan@broadcom•com>
Cc: davem@davemloft•net, netdev@vger•kernel.org, edumazet@google•com,
pabeni@redhat•com, andrew+netdev@lunn•ch,
pavan.chebbi@broadcom•com, andrew.gospodarek@broadcom•com,
Somnath Kotur <somnath.kotur@broadcom•com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom•com>
Subject: Re: [PATCH net-next 4/6] bnxt_en: Defrag the NVRAM region when resizing UPDATE region fails
Date: Tue, 6 Jan 2026 18:19:26 -0800 [thread overview]
Message-ID: <20260106181926.4d561295@kernel.org> (raw)
In-Reply-To: <20260105215833.46125-5-michael.chan@broadcom.com>
On Mon, 5 Jan 2026 13:58:31 -0800 Michael Chan wrote:
> + if (rc == -ENOSPC) {
> + if (retry || bnxt_hwrm_nvm_defrag(bp))
> + break;
> + retry = true;
> + }
> + } while (rc == -ENOSPC && retry);
Since there's an explicit break under rc == ENOSPC + retry
the while loop doesn't need to check retry.
Something needs to be cleaned up here
next prev parent reply other threads:[~2026-01-07 2:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 21:58 [PATCH net-next 0/6] bnxt_en: Updates for net-next Michael Chan
2026-01-05 21:58 ` [PATCH net-next 1/6] bnxt_en: Update FW interface to 1.10.3.151 Michael Chan
2026-01-05 21:58 ` [PATCH net-next 2/6] bnxt_en: Add PTP .getcrosststamp() interface to get device/host times Michael Chan
2026-01-05 22:18 ` Vadim Fedorenko
2026-01-05 21:58 ` [PATCH net-next 3/6] bnxt_en: Add support for FEC bin histograms Michael Chan
2026-01-06 12:07 ` Vadim Fedorenko
2026-01-05 21:58 ` [PATCH net-next 4/6] bnxt_en: Defrag the NVRAM region when resizing UPDATE region fails Michael Chan
2026-01-07 2:19 ` Jakub Kicinski [this message]
2026-01-05 21:58 ` [PATCH net-next 5/6] bnxt_en: Use a larger RSS indirection table on P5_PLUS chips Michael Chan
2026-01-05 21:58 ` [PATCH net-next 6/6] bnxt_en: Implement ethtool_ops -> get_link_ext_state() Michael Chan
2026-01-07 2:15 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260106181926.4d561295@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew.gospodarek@broadcom$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=kalesh-anakkur.purayil@broadcom$(echo .)com \
--cc=michael.chan@broadcom$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=pavan.chebbi@broadcom$(echo .)com \
--cc=somnath.kotur@broadcom$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox