From: Jakub Kicinski <kuba@kernel•org>
To: Cong Wang <xiyou.wangcong@gmail•com>
Cc: Stephen Hemminger <stephen@networkplumber•org>,
netdev@vger•kernel.org, William Liu <will@willsroot•io>,
Savino Dicanosa <savy@syst3mfailure•io>
Subject: Re: [Patch net v6 4/8] net_sched: Implement the right netem duplication behavior
Date: Wed, 7 Jan 2026 18:18:33 -0800 [thread overview]
Message-ID: <20260107181833.692a9ea1@kernel.org> (raw)
In-Reply-To: <aV7tYRnVikZXAC23@pop-os.localdomain>
On Wed, 7 Jan 2026 15:33:53 -0800 Cong Wang wrote:
> > It is worth testing for the case where netem is used as a leaf qdisc.
> > I worry that this could cause the parent qdisc to get accounting wrong.
> > I.e if HTB calls netem and netem queues 2 packets, the qlen in HTB
> > would be incorrect.
>
> In patch 6/8, I added "Test PRIO with NETEM duplication", which installs
> netem Qdisc as a child and leaf of root prio qdisc.
>
> Or am I misunderstanding it?
Does something automatically validates that backlog is 0 when qdisc is
destroyed? The test itself only checks:
"matchPattern": "Sent \\d+ bytes (\\d+) pkt",
next prev parent reply other threads:[~2026-01-08 2:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-27 19:41 [Patch net v6 0/8] netem: Fix skb duplication logic and prevent infinite loops Cong Wang
2025-12-27 19:41 ` [Patch net v6 1/8] net_sched: Check the return value of qfq_choose_next_agg() Cong Wang
2025-12-30 17:24 ` Stephen Hemminger
2025-12-27 19:41 ` [Patch net v6 2/8] Revert "net/sched: Restrict conditions for adding duplicating netems to qdisc tree" Cong Wang
2025-12-27 19:41 ` [Patch net v6 3/8] Revert "selftests/tc-testing: Add tests for restrictions on netem duplication" Cong Wang
2025-12-27 19:41 ` [Patch net v6 4/8] net_sched: Implement the right netem duplication behavior Cong Wang
2025-12-30 17:28 ` Stephen Hemminger
2026-01-04 19:19 ` Jakub Kicinski
2026-01-07 23:33 ` Cong Wang
2026-01-08 2:18 ` Jakub Kicinski [this message]
2025-12-27 19:41 ` [Patch net v6 5/8] selftests/tc-testing: Add a nested netem duplicate test Cong Wang
2025-12-27 19:41 ` [Patch net v6 6/8] selftests/tc-testing: Add a test case for piro with netem duplicate Cong Wang
2026-01-04 19:15 ` Jakub Kicinski
2026-01-07 23:34 ` Cong Wang
2025-12-27 19:41 ` [Patch net v6 7/8] selftests/tc-testing: Add a test case for mq " Cong Wang
2025-12-27 19:41 ` [Patch net v6 8/8] selftests/tc-testing: Update test cases " Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260107181833.692a9ea1@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=savy@syst3mfailure$(echo .)io \
--cc=stephen@networkplumber$(echo .)org \
--cc=will@willsroot$(echo .)io \
--cc=xiyou.wangcong@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox