From: Simon Horman <horms@kernel•org>
To: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
Cc: netdev@vger•kernel.org, Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Jakub Kicinski <kuba@kernel•org>, Paolo Abeni <pabeni@redhat•com>,
Wen Gu <guwen@linux•alibaba.com>,
Philo Lu <lulie@linux•alibaba.com>,
Vadim Fedorenko <vadim.fedorenko@linux•dev>,
Lorenzo Bianconi <lorenzo@kernel•org>,
Lukas Bulwahn <lukas.bulwahn@redhat•com>,
Dong Yibo <dong100@mucse•com>,
Vivian Wang <wangruikang@iscas•ac.cn>,
MD Danish Anwar <danishanwar@ti•com>,
Dust Li <dust.li@linux•alibaba.com>
Subject: Re: [PATCH net-next v18 4/6] eea: create/destroy rx,tx queues for netdevice open and stop
Date: Thu, 8 Jan 2026 08:17:48 +0000 [thread overview]
Message-ID: <20260108081748.GF345651@kernel.org> (raw)
In-Reply-To: <20260105110712.22674-5-xuanzhuo@linux.alibaba.com>
On Mon, Jan 05, 2026 at 07:07:10PM +0800, Xuan Zhuo wrote:
> Add basic driver framework for the Alibaba Elastic Ethernet Adapter(EEA).
>
> This commit introduces the implementation for the netdevice open and
> stop.
>
> Reviewed-by: Dust Li <dust.li@linux•alibaba.com>
> Reviewed-by: Philo Lu <lulie@linux•alibaba.com>
> Signed-off-by: Wen Gu <guwen@linux•alibaba.com>
> Signed-off-by: Xuan Zhuo <xuanzhuo@linux•alibaba.com>
...
> diff --git a/drivers/net/ethernet/alibaba/eea/eea_net.c b/drivers/net/ethernet/alibaba/eea/eea_net.c
...
> +/* resources: ring, buffers, irq */
> +int eea_reset_hw_resources(struct eea_net *enet, struct eea_net_init_ctx *ctx)
> +{
> + int err;
> +
> + if (!netif_running(enet->netdev)) {
> + enet->cfg = ctx->cfg;
> + return 0;
> + }
> +
> + err = eea_alloc_rxtx_q_mem(ctx);
> + if (err) {
> + netdev_warn(enet->netdev,
> + "eea reset: alloc q failed. stop reset. err %d\n",
> + err);
> + return err;
> + }
> +
> + eea_netdev_stop(enet->netdev);
> +
> + enet_bind_new_q_and_cfg(enet, ctx);
> +
> + err = eea_active_ring_and_irq(enet);
> + if (err) {
> + netdev_warn(enet->netdev,
> + "eea reset: active new ring and irq failed. err %d\n",
> + err);
> + return err;
> + }
I think that some unwinding of resources is needed if
eea_active_ring_and_irq() or eea_start_rxtx() fail.
Similar to what appears in eea_netdev_open().
Also flagged by Claude Code with Review Prompts.
> +
> + err = eea_start_rxtx(enet->netdev);
> + if (err)
> + netdev_warn(enet->netdev,
> + "eea reset: start queue failed. err %d\n", err);
> +
> + return err;
> +}
...
> diff --git a/drivers/net/ethernet/alibaba/eea/eea_tx.c b/drivers/net/ethernet/alibaba/eea/eea_tx.c
...
> +static void eea_free_meta(struct eea_net_tx *tx, struct eea_net_cfg *cfg)
> +{
> + struct eea_sq_free_stats stats;
> + struct eea_tx_meta *meta;
> + int i;
> +
> + while ((meta = eea_tx_meta_get(tx)))
> + meta->skb = NULL;
> +
> + for (i = 0; i < cfg->tx_ring_num; i++) {
> + meta = &tx->meta[i];
> +
> + if (!meta->skb)
> + continue;
> +
> + eea_meta_free_xmit(tx, meta, false, NULL, &stats);
> +
> + meta->skb = NULL;
> + }
Claude Code running with Review Prompts [1] flags that
in the loop above cfg->tx_ring_num is used as the bounds
for access to tx->meta. But elsewhere, including in the
allocation of tx->meta, ctx->cfg.tx_ring_depth is used.
[1] https://github.com/masoncl/review-prompts/
> +
> + kvfree(tx->meta);
> + tx->meta = NULL;
> +}
...
next prev parent reply other threads:[~2026-01-08 8:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-05 11:07 [PATCH net-next v18 0/6] eea: Add basic driver framework for Alibaba Elastic Ethernet Adaptor Xuan Zhuo
2026-01-05 11:07 ` [PATCH net-next v18 1/6] eea: introduce PCI framework Xuan Zhuo
2026-01-07 19:52 ` Simon Horman
2026-01-05 11:07 ` [PATCH net-next v18 2/6] eea: introduce ring and descriptor structures Xuan Zhuo
2026-01-05 11:07 ` [PATCH net-next v18 3/6] eea: probe the netdevice and create adminq Xuan Zhuo
2026-01-05 11:07 ` [PATCH net-next v18 4/6] eea: create/destroy rx,tx queues for netdevice open and stop Xuan Zhuo
2026-01-08 8:17 ` Simon Horman [this message]
2026-01-05 11:07 ` [PATCH net-next v18 5/6] eea: introduce ethtool support Xuan Zhuo
2026-01-05 11:07 ` [PATCH net-next v18 6/6] eea: introduce callback for ndo_get_stats64 Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108081748.GF345651@kernel.org \
--to=horms@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=danishanwar@ti$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=dong100@mucse$(echo .)com \
--cc=dust.li@linux$(echo .)alibaba.com \
--cc=edumazet@google$(echo .)com \
--cc=guwen@linux$(echo .)alibaba.com \
--cc=kuba@kernel$(echo .)org \
--cc=lorenzo@kernel$(echo .)org \
--cc=lukas.bulwahn@redhat$(echo .)com \
--cc=lulie@linux$(echo .)alibaba.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
--cc=wangruikang@iscas$(echo .)ac.cn \
--cc=xuanzhuo@linux$(echo .)alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox