From: Jakub Kicinski <kuba@kernel•org>
To: Heiner Kallweit <hkallweit1@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>, Andrew Lunn <andrew+netdev@lunn•ch>,
Russell King - ARM Linux <linux@armlinux•org.uk>,
Paolo Abeni <pabeni@redhat•com>,
Eric Dumazet <edumazet@google•com>,
David Miller <davem@davemloft•net>,
"netdev@vger•kernel.org" <netdev@vger•kernel.org>
Subject: Re: [PATCH net-next] net: phy: fixed_phy: replace list of fixed PHYs with static array
Date: Thu, 8 Jan 2026 18:11:02 -0800 [thread overview]
Message-ID: <20260108181102.4553d618@kernel.org> (raw)
In-Reply-To: <e14f6119-9bf9-4e9d-8e14-a8cb884cbd5c@gmail.com>
On Tue, 6 Jan 2026 17:56:26 +0100 Heiner Kallweit wrote:
> +/* The DSA loop driver may allocate 4 fixed PHY's, and 4 additional
> + * fixed PHY's for a system should be sufficient.
> + */
> +#define NUM_FP 8
> +
> struct fixed_phy {
> - int addr;
> struct phy_device *phydev;
> struct fixed_phy_status status;
> int (*link_update)(struct net_device *, struct fixed_phy_status *);
> - struct list_head node;
> };
>
> +static struct fixed_phy fmb_fixed_phys[NUM_FP];
> static struct mii_bus *fmb_mii_bus;
> -static LIST_HEAD(fmb_phys);
> +static DEFINE_IDA(phy_fixed_ida);
Isn't IDA an overkill for a range this tiny?
IDA is useful if the ID range is large and may be sparse.
Here a bitmap would suffice.
DECLARE_BITMAP(phy_fixed_ids, NUM_FP);
id = find_first_zero_bit(phy_fixed_ids, NUM_FP);
if (id >= NUM_FP)
return -ENOSPC;
set_bit(id, phy_fixed_ids);
...
next prev parent reply other threads:[~2026-01-09 2:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 16:56 [PATCH net-next] net: phy: fixed_phy: replace list of fixed PHYs with static array Heiner Kallweit
2026-01-06 17:51 ` Russell King (Oracle)
2026-01-09 2:11 ` Jakub Kicinski [this message]
2026-01-09 11:00 ` Heiner Kallweit
2026-01-09 14:43 ` Jakub Kicinski
2026-01-09 15:10 ` Russell King (Oracle)
2026-01-09 16:31 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108181102.4553d618@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=edumazet@google$(echo .)com \
--cc=hkallweit1@gmail$(echo .)com \
--cc=linux@armlinux$(echo .)org.uk \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox