Subject: Re: [PATCH net-next] xgbe: Use netlink extack to report errors to ethtool

From: Jakub Kicinski <[email-masked]>
Date: Fri, 9 Jan 2026 06:25:21 -0800

On Fri, 9 Jan 2026 13:17:46 +0530 Raju Rangoju wrote:
>  	if (ringparam->rx_mini_pending || ringparam->rx_jumbo_pending) {
> -		netdev_err(netdev, "unsupported ring parameter\n");
> +		NL_SET_ERR_MSG_FMT_MOD(extack, "unsupported ring parameter\n");
>  		return -EINVAL;
>  	}

There should be no \n at the end of the extack string.
Please don't use _FMT if there's no formatting going on.
-- 
pw-bot: cr