Subject: Re: [PATCH net-next v3] octeon_ep: reset firmware ready status

From: Jakub Kicinski <[email-masked]>
Date: Sat, 10 Jan 2026 12:13:49 -0800

On Wed, 7 Jan 2026 13:45:02 +0000 Vimlesh Kumar wrote:
> +#define CN9K_PEMX_PFX_CSX_PFCFGX(pem, pf, offset)\
> +				 ({ typeof(offset) _off = (offset);\
> +				 ((CN9K_PFX_CSX_PFCFGX_BASE_ADDR\
> +				 | (uint64_t)FIELD_PREP(CN9K_PEM_GENMASK, pem)\
> +				 | FIELD_PREP(CN9K_PF_GENMASK, pf)\
> +				 | (CN9K_PFX_CSX_PFCFGX_SHADOW_BIT & (_off))\
> +				 | (rounddown((_off), 8)))\
> +				 + (CN9K_4BYTE_ALIGNED_ADDRESS_OFFSET(_off)));\
> +				 })

This macro is completely unreadable. Maybe add a static inline to
perform the CN9K_PEMX_PFX_CSX_PFCFGX() writes.
-- 
pw-bot: cr