Subject: Re: [PATCH net-next v3 01/13] octeontx2-af: npc: cn20k: Index management

From: Jakub Kicinski <[email-masked]>
Date: Sat, 10 Jan 2026 14:51:14 -0800

On Fri, 9 Jan 2026 11:18:16 +0530 Ratheesh Kannoth wrote:
> +/**
> + * struct npc_priv_t - NPC private structure.
> + * @bank_depth:		Total entries in each bank.
> + * @num_banks:		Number of banks.
> + * @subbank_depth:	Depth of subbank.
> + * @kw:			Kex configured key type.
> + * @sb:			Subbank array.
> + * @xa_sb_used:		Array of used subbanks.
> + * @xa_sb_free:		Array of free subbanks.
> + * @xa_pf2idx_map:	PF to mcam index map.
> + * @xa_idx2pf_map:	Mcam index to PF map.
> + * @xa_pf_map:		Pcifunc to index map.
> + * @pf_cnt:		Number of PFs.A
> + * @init_don:		Indicates MCAM initialization is done.
> + *
> + * This structure is populated during probing time by reading
> + * HW csr registers.
> + */
> +struct npc_priv_t {
> +	int bank_depth;
> +	const int num_banks;
> +	int num_subbanks;
> +	int subbank_depth;
> +	u8 kw;				/* Kex configure Keywidth. */
> +	struct npc_subbank *sb;		/* Array of subbanks */
> +	struct xarray xa_sb_used;	/* xarray of used subbanks */
> +	struct xarray xa_sb_free;	/* xarray of free subbanks */
> +	struct xarray *xa_pf2idx_map;	/* Each PF to map its mcam idxes */
> +	struct xarray xa_idx2pf_map;	/* Mcam idxes to pf map. */
> +	struct xarray xa_pf_map;	/* pcifunc to index map. */
> +	int pf_cnt;
> +	bool init_done;
> +};

Warning: drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h:93 struct member 'num_subbanks' not described in 'npc_priv_t'
Warning: drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h:93 struct member 'init_done' not described in 'npc_priv_t'
Warning: drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h:93 struct member 'num_subbanks' not described in 'npc_priv_t'
Warning: drivers/net/ethernet/marvell/octeontx2/af/cn20k/npc.h:93 struct member 'init_done' not described in 'npc_priv_t'
-- 
pw-bot: cr