Subject: Re: [PATCH net] amd-xgbe: avoid misleading per-packet error log

From: Jakub Kicinski <[email-masked]>
Date: Mon, 12 Jan 2026 19:28:12 -0800

On Sat, 10 Jan 2026 22:34:22 +0530 Raju Rangoju wrote:
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> index 0d19b09497a0..c8797a338542 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-ethtool.c
> @@ -75,6 +75,8 @@ static const struct xgbe_stats xgbe_gstring_stats[] = {
>  	XGMAC_MMC_STAT("rx_pause_frames", rxpauseframes),
>  	XGMAC_EXT_STAT("rx_split_header_packets", rx_split_header_packets),
>  	XGMAC_EXT_STAT("rx_buffer_unavailable", rx_buffer_unavailable),
> +	XGMAC_EXT_STAT("rx_buffer_overflow", rx_buffer_overflow),

"rx_buffer_overflow" sounds like something that should be categorized
to one of the struct rtnl_link_stats64 stats. See the kdoc in if_link.h

> +	XGMAC_EXT_STAT("rx_pkt_errors", rx_pkt_errors),

Are these counted to standard rx_errors somewhere?
-- 
pw-bot: cr