Subject: Re: [PATCH net v1 3/3] net/sched: act_gate: zero-initialize netlink dump struct

From: Jakub Kicinski <[email-masked]>
Date: Mon, 19 Jan 2026 11:14:52 -0800

On Fri, 16 Jan 2026 11:26:08 +0000 Paul Moses wrote:
> -	unsigned char *b = skb_tail_pointer(skb);
>  	struct tcf_gate *gact = to_gate(a);
> -	struct tc_gate opt = {
> -		.index    = gact->tcf_index,
> -		.refcnt   = refcount_read(&gact->tcf_refcnt) - ref,
> -		.bindcnt  = atomic_read(&gact->tcf_bindcnt) - bind,
> -	};
>  	struct tcfg_gate_entry *entry;
>  	struct tcf_gate_params *p;
>  	struct nlattr *entry_list;
> +	struct tc_gate opt = { };
>  	struct tcf_t t;
> +	unsigned char *b = skb_tail_pointer(skb);

Why is *b moving? Please avoid unnecessary code changes in fixes.

Also -- we prefer the declaration lines to be sorted longest to
shortest. If a dependency prevents that the init needs to be moved
to the body of the function (this mostly applies to patch 2).