Subject: Re: [PATCH net-next 1/2] net: extend ndo_get_tstamp for other timestamp types

From: Jakub Kicinski <[email-masked]>
Date: Mon, 19 Jan 2026 11:57:10 -0800

On Thu, 15 Jan 2026 22:22:59 +0000 Kevin Yang wrote:
> Reviewed-by: Willem de Bruijn <[email-masked]>

Other than expediency why implementing this in drivers makes sense?
There will be very little driver specific logic here.

After thinking about it for 1 minute my intuition would be for drivers
to just expose necessary information, in-kernel consumers should
"enable" the sync for all netdevs during init, and then convert
the timestamps into REALTIME / MONOTONIC by calling some helper?

Also AI code review says:

> +		mult = mult_frac(GVE_HWTS_REAL_CC_NOMINAL,
> +				 real_ns - priv->ts_real.last_sync_ns,
> +				 priv->last_sync_nic_counter - prev_nic);

Can this divide by zero? 
-- 
pw-bot: cr