From: Jakub Kicinski <kuba@kernel•org>
To: Vivian Wang <wangruikang@iscas•ac.cn>
Cc: Andrew Lunn <andrew+netdev@lunn•ch>,
"David S. Miller" <davem@davemloft•net>,
Eric Dumazet <edumazet@google•com>,
Paolo Abeni <pabeni@redhat•com>, Yixun Lan <dlan@gentoo•org>,
Chukun Pan <amadeus@jmu•edu.cn>,
Michael Opdenacker <michael.opdenacker@rootcommit•com>,
netdev@vger•kernel.org, linux-riscv@lists•infradead.org,
spacemit@lists•linux.dev, linux-kernel@vger•kernel.org
Subject: Re: [PATCH net v2] net: spacemit: Clarify stat timeout comments and messages
Date: Thu, 22 Jan 2026 07:30:43 -0800 [thread overview]
Message-ID: <20260122073043.3089d435@kernel.org> (raw)
In-Reply-To: <5639ff0c-dfd1-4528-a0ce-92d3c457ce64@iscas.ac.cn>
On Thu, 22 Jan 2026 18:39:06 +0800 Vivian Wang wrote:
> > Because if it's the latter we should be able to skip reading the stats
> > when link is down (still racy but better than waiting in cases we can
> > detect?)
>
> If checking the link is definitely up as a condition for updating stats
> would be acceptable, then maybe the original patch from the linked
> thread [2] can also be adopted?
Yes, speaking under correction if Andrew disagrees, but could you
squash those two patches ([2] and the v2) into one?
prev parent reply other threads:[~2026-01-22 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 2:17 [PATCH net v2] net: spacemit: Clarify stat timeout comments and messages Vivian Wang
2026-01-22 4:04 ` Jakub Kicinski
2026-01-22 10:39 ` Vivian Wang
2026-01-22 11:51 ` Paolo Abeni
2026-01-22 15:30 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260122073043.3089d435@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=amadeus@jmu$(echo .)edu.cn \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=dlan@gentoo$(echo .)org \
--cc=edumazet@google$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=michael.opdenacker@rootcommit$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=pabeni@redhat$(echo .)com \
--cc=spacemit@lists$(echo .)linux.dev \
--cc=wangruikang@iscas$(echo .)ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox