Subject: Re: [PATCH net-next 1/6] eth: bnxt: always set the queue mgmt ops

From: Subbaraya Sundeep <[email-masked]>
Date: Thu, 22 Jan 2026 22:01:49 +0530

On 2026-01-22 at 21:06:43, Jakub Kicinski ([email-masked]) wrote:
> On Thu, 22 Jan 2026 13:34:20 +0530 Subbaraya Sundeep wrote:
> > > +
> > > +	dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops_unsupp;
> > >  	if (BNXT_SUPPORTS_QUEUE_API(bp))
> > >  		dev->queue_mgmt_ops = &bnxt_queue_mgmt_ops;
> > > -	dev->request_ops_lock = true;  
> > 
> > Can we also mention that driver with queue_mgmt_ops set makes it as ops locked
> > driver in Documentation/networking/netdevices.rst ?
> 
> Did you check if it's already documented there before asking me to do
> it? I know people don't read docs much but asking someone to document
> stuff that's already documented is a bit funny..

Okay it is there:

"Note that supporting struct netdev_queue_mgmt_ops automatically enables
"ops locking". "

Reviewed-by: Subbaraya Sundeep <[email-masked]>

Thanks,
Sundeep