From: Jakub Kicinski <kuba@kernel•org>
To: Florian Fainelli <florian.fainelli@broadcom•com>
Cc: Mohsin Bashir <mohsin.bashr@gmail•com>,
netdev@vger•kernel.org, alexanderduyck@fb•com,
alok.a.tiwari@oracle•com, andrew+netdev@lunn•ch, andrew@lunn•ch,
chuck.lever@oracle•com, davem@davemloft•net,
donald.hunter@gmail•com, edumazet@google•com, gal@nvidia•com,
horms@kernel•org, idosch@nvidia•com, jacob.e.keller@intel•com,
kernel-team@meta•com, kory.maincent@bootlin•com, lee@trager•us,
o.rempel@pengutronix•de, pabeni@redhat•com,
vadim.fedorenko@linux•dev
Subject: Re: [PATCH net-next 0/3] net: ethtool: Track TX pause storm
Date: Fri, 23 Jan 2026 12:05:12 -0800 [thread overview]
Message-ID: <20260123120512.162ae4d9@kernel.org> (raw)
In-Reply-To: <7ab606d1-9f65-4123-827e-58650eb8944a@broadcom.com>
On Fri, 23 Jan 2026 11:36:33 -0800 Florian Fainelli wrote:
> On 1/22/26 11:21, Mohsin Bashir wrote:
> > With TX pause enabled, if a device cannot deliver received frames to
> > the stack (e.g., during a system hang), it may generate excessive pause
> > frames causing a pause storm. This series updates the uAPI to track TX
> > pause storm events as part of the pause stats (p1), adds pause storm
> > protection support for fbnic (p2), and leverages p1 to provide
> > observability into these events for fbnic (p3).
>
> Jakub, should I go ahead and re-submit this patch series then:
>
> https://patchew.org/linux/20251107002510.1678369-1-florian.fainelli@broadcom.com/
Sounded like Oleksij is also interested so let's go ahead.
Presumably an attr in ethtool -a/-A ?
> Looks like this is exactly what you ran into here.
Kinda, the machines reboot on panic. The problematic cases are those
that crashed in a way that didn't trigger normal reboot cycle.
Or got wedge somewhere funny.
prev parent reply other threads:[~2026-01-23 20:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 19:21 [PATCH net-next 0/3] net: ethtool: Track TX pause storm Mohsin Bashir
2026-01-22 19:21 ` [PATCH net-next 1/3] net: ethtool: Track pause storm events Mohsin Bashir
2026-01-23 21:27 ` Oleksij Rempel
2026-01-23 22:15 ` Jakub Kicinski
2026-01-24 9:28 ` Oleksij Rempel
2026-01-22 19:21 ` [PATCH net-next 2/3] eth: fbnic: Add protection against pause storm Mohsin Bashir
2026-01-22 19:21 ` [PATCH net-next 3/3] eth: fbnic: Fetch TX pause storm stats Mohsin Bashir
2026-01-23 9:34 ` [PATCH net-next 0/3] net: ethtool: Track TX pause storm Oleksij Rempel
2026-01-23 11:28 ` Oleksij Rempel
2026-01-23 18:40 ` Jakub Kicinski
2026-01-23 19:31 ` Mohsin Bashir
2026-01-23 21:04 ` Oleksij Rempel
2026-01-23 22:21 ` Jakub Kicinski
2026-01-25 9:59 ` Gal Pressman
2026-01-25 22:30 ` Jakub Kicinski
2026-01-26 6:51 ` Gal Pressman
2026-01-23 19:36 ` Florian Fainelli
2026-01-23 20:05 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260123120512.162ae4d9@kernel.org \
--to=kuba@kernel$(echo .)org \
--cc=alexanderduyck@fb$(echo .)com \
--cc=alok.a.tiwari@oracle$(echo .)com \
--cc=andrew+netdev@lunn$(echo .)ch \
--cc=andrew@lunn$(echo .)ch \
--cc=chuck.lever@oracle$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=donald.hunter@gmail$(echo .)com \
--cc=edumazet@google$(echo .)com \
--cc=florian.fainelli@broadcom$(echo .)com \
--cc=gal@nvidia$(echo .)com \
--cc=horms@kernel$(echo .)org \
--cc=idosch@nvidia$(echo .)com \
--cc=jacob.e.keller@intel$(echo .)com \
--cc=kernel-team@meta$(echo .)com \
--cc=kory.maincent@bootlin$(echo .)com \
--cc=lee@trager$(echo .)us \
--cc=mohsin.bashr@gmail$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=o.rempel@pengutronix$(echo .)de \
--cc=pabeni@redhat$(echo .)com \
--cc=vadim.fedorenko@linux$(echo .)dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox